WFLY-14544 Review for expansion expression testing in singleton subsystem #14100
Conversation
github-actions
bot
added
the
deps-ok
|
@pferraro Please review. |
…support expressions since they are capability references
| @@ -81,6 +81,7 @@ static PathElement pathElement(String value) { | |||
|
|
|||
| Attribute(String name, String alternative, CapabilityReferenceRecorder reference) { | |||
| this.definition = createBuilder(name, alternative) | |||
| .setAllowExpression(false) | |||
There was a problem hiding this comment.
@bstansberry Can you confirm that disallowing expressions where previously inadvertently enabled (since these are capability references) does not require model version bump (given there is nothing to transform)?
There was a problem hiding this comment.
@rhusar I think it's ok here to not bump.
The AD stuff can be a bit tricky because it both describes the API, and thus is similar to javadoc, but it also controls behavior in some cases, e.g. setAllowExpression ends up driving validation of requests.
If an AD change basically just amounts to a 'javadoc correction' it doesn't require a bump. If it actually changes behavior, it requires a bump.
In this case the attribute has been a capability reference back to 2015 so presumably an expression would not have worked for a long time. So no behavior change and this is just a 'javadoc correction'.
Resolves
https://issues.redhat.com/browse/WFLY-14544
https://issues.redhat.com/browse/WFLY-14545