WFLY-14971 Singleton deployment tests still failing intermittently #14422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Infinispan TopologyChanged events instead of JGroups view change events.
|
Adding hold label until verified via sufficient CI runs. |
github-actions
bot
added
the
deps-ok
|
So far, so good. I will focus rerunning Linux SM - JDK 8 jobs, as these test seem to fail most often with that configuration. |
|
@rhusar Please review. |
|
This looks good now. No singleton deployment test failures seen. |
rhusar
reviewed
Jul 14, 2021
Comment on lines
-8
to
-12
| /** | ||
| * @TypeId(140) | ||
| */ | ||
| message GetLocalServicesCommand { | ||
| } |
There was a problem hiding this comment.
I am under impression that proto types should be commented out rather than removed so the IDs don't get inadvertently reused?
There was a problem hiding this comment.
We are not yet guaranteeing serialization compatibility across major releases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WFLY-14971