Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Narayana to 5.12.4.Final #14974

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Conversation

mmusgrov
Copy link
Contributor

Resolves https://issues.redhat.com/browse/WFLY-15753
The issue link contains the release tag and the changeset and the release notes.

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Nov 29, 2021
@bstansberry
Copy link
Contributor

@mmusgrov This has a merge conflict. I'd be happy to resolve it via the GH UI if you'd like.

@mmusgrov
Copy link
Contributor Author

mmusgrov commented Dec 2, 2021

Thanks @bstansberry . But wait, note that 5.12.4.Final has introduced a performance regression of the transaction log store. I've been trying to track it down this week (the perf jobs take the best part of a day to run). In other words, if you do merge it then I think we will need another narayana release before 26.0.0 can be released. So maybe it's best to wait for that first.

@darranl darranl added the hold PR should not be merged for some reason. label Dec 3, 2021
@darranl
Copy link
Contributor

darranl commented Dec 3, 2021

Just added a hold label whilst the regression is reviewed, we can remove once we are ready to proceed.

@mmusgrov
Copy link
Contributor Author

mmusgrov commented Dec 6, 2021

@darranl will you to do the same with #14975 ([WFLY-15548] [WFLY-15446] transaction subsystem: jakarta namespance) please.

@bstansberry
Copy link
Contributor

Hi @mmusgrov -- is 5.12.2 a possible interim step? I think doing that would unblock #15017

@mmusgrov
Copy link
Contributor Author

mmusgrov commented Jan 17, 2022

@bstansberry The regression is in org.apache.activemq:artemis-journal:2.18.0 and

5.12.2.Final uses 2.18.0
5.12.1.Final uses 2.16.0

so we would need to go back to using 5.12.1.Final

The fix for the regression is apache/activemq-artemis@52fcc0c
so we need to wait for a release that contains that.

@bstansberry
Copy link
Contributor

Thanks, @mmusgrov!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps-ok Dependencies have been checked, and there are no significant changes hold PR should not be merged for some reason. rebase-this PR has a merge conflict.
Projects
None yet
3 participants