[WFLY-15548] [WFLY-15446] transaction subsystem: jakarta namespance p… #14975

mmusgrov · 2021-11-29T14:06:14Z

https://issues.redhat.com/browse/WFLY-15548 (the transaction subsystem module)
https://issues.redhat.com/browse/WFLY-15446 (I think this issue is superfluous and I've asked on the issue for clarification)

WildFly Preview for the Jakarta namespace variant of the transaction subsystem module.

Remark: this PR also upgrades the narayana component for which I have raised a separate #14974

yersan · 2021-11-29T16:58:16Z

ee-9/source-transform/transactions/pom.xml

+        <version>26.0.0.Beta1-SNAPSHOT</version>
+    </parent>
+
+    <artifactId>wildfly-transactions-jakarta</artifactId>


Hello @mmusgrov , if this is not a work in progress PR, essentially, this is just adding a new maven module. You also need to use it for the wildfly-preview feature pack.

From the Brian's tutorial, I'm missing the steps from 9) to 13) for this PR

thanks for the link, I will update the PR

@yersan the latest version of narayana (5.12.4.Final), which is included in this PR, has introduced a performance regression of the transaction log store. I've been trying to track it down this week (the perf jobs takes the best part of a day to run). If we go ahead with this PR then we will still need another narayana release before 26.0.0 can be released.

@yersan Just an FYI, we plan to merge the narayana component upgrade with the regression and follow up asap once the dependent library has been fixed (the current plan is sometime next week for the dependency to be fixed).

And I updated my branch to add the missing steps from 9) to 13) but the build fails on the wildfly-preview-feature-pack module and I don't know how to debug that so I asked the question in the wildfly forums (https://lists.jboss.org/archives/list/wildfly-dev@lists.jboss.org/thread/ZCXWAOVBRTOI247RZQ4X5UUVEITI3ZQJ/). Is that the best place to ask that question?

Hi @mmusgrov , I reply to your question in the WildFly dev List. If you still have trouble building it, feel free to upgrade the PR with what you have and we can discuss the details here on GitHub.

Thanks @yersan for the debug tip which shows the reason for the failure:

Caused by: java.lang.IllegalStateException: WFLYCTL0153: No META-INF/services/org.jboss.as.controller.Extension found for org.jboss.as.transactions

We have one of those in the subsystem code:

<WFLY repo>/transactions/src/main/resources/META-INF/services/org.jboss.as.controller.Extension

Do we also need one somewhere in the ee-9 part of the source tree?

@mmusgrov No really, none of the other subsystems already transformed do anything related to these kinds of services.

I'm not sure about your current structure, can you push your latest version of this PR so we can see what you have at the moment and suggest what is still missing?

@yersan I have pushed my updates for steps 9) to 13)

yersan · 2021-11-29T16:59:13Z

ee-9/source-transform/transactions/pom.xml

+            <version>5.12.4.Final</version>
+        </dependency>
+        <dependency>
+            <groupId>org.jboss.narayana.jts</groupId>
+            <artifactId>narayana-jts-integration-jakarta</artifactId>
+            <version>5.12.4.Final</version>


These modules should be inherited from the main ee-9/pom.xml

darranl · 2021-12-06T11:25:28Z

Just adding hold as requested by @mmusgrov

yersan · 2022-01-24T12:31:08Z

ee-9/feature-pack/pom.xml

+                <exclusion>
+                    <groupId>${ee.maven.groupId}</groupId>
+                    <artifactId>wildfly-transactions-jakarta</artifactId>
+                </exclusion>


The idea behind this is to avoid introducing in the build classpath the Jakarta EE 8 extension. The exclusion here should be:

<exclusion> <groupId>${ee.maven.groupId}</groupId> <artifactId>wildfly-transactions</artifactId> </exclusion>

@mmusgrov That's probably the root of your issue with the missing service.

@yersan I pushed the update but I still get the same issue after making that change.

I missed two of your comments, I am retesting after addressing those.

@yersan But I still get the error. Do you still have your branch where you managed to get it working, if so I can clone that and use it to compare with my updates after addressing your comments?

@mmusgrov The build succeeds if you place the missing dependencies before wildfly-iiop-openjdk, which indeed is wrong, we should use wildfly-iiop-openjdk-jarkarta.

Having said that, there is still additional work to do:

Use wildfly-iiop-openjdk-jarkarta instead of wildfly-iiop-openjdk

Exclude whatever is not needed from the wildfly-ee-feature-pack-common, e.g narayana-jts-integration,narayana-jts-idlj and wildfly-iiop-openjdk. I've noticed they are still being transformed, but they shouldn't.

Avoid the build being dependent on the dependency order declaration, it should work if you place the dependencies at the beginning or at the end.

Let me know if you want me to take a closer look at all of this.

@yersan
Which missing dependencies?
Which dependencies depend on the order of declaration?

And the build still fails with the same error WFLYCTL0153: No META-INF/services/org.jboss.as.controller.Extension found for org.jboss.as.transactions after addressing your first two bullets. These extra requirements are not mentioned in Brian's document so I am just guessing at these extra items you say I need.

I would take you up on your offer of "taking a closer look at all of this" but, since I am just guessing at these extra items I will have the same problems with the other systems I have pending updates for, namely wildfly-rts-jakarta and wildfly-xts-jakarta, and I suspect your good will won't extend that far.

…review

yersan · 2022-01-24T14:54:05Z

ee-9/source-transform/transactions/pom.xml

+    <name>WildFly: Transaction Subsystem (Jakarta Namespace)</name>
+
+    <properties>
+        <transformer-input-dir>${project.basedir}/../../../../transactions</transformer-input-dir>


Found that this module is three levels above the transactions module, instead of four. So, replace it by:

<transformer-input-dir>${project.basedir}/../../../transactions</transformer-input-dir>

yersan · 2022-01-24T14:57:11Z

ee-9/source-transform/transactions/pom.xml

+    <dependencies>
+        <dependency>
+            <groupId>org.wildfly.core</groupId>
+            <artifactId>wildfly-controller</artifactId>
+        </dependency>
+        <dependency>
+            <groupId>${project.groupId}</groupId>
+            <artifactId>wildfly-ee-jakarta</artifactId>
+        </dependency>
+        <dependency>
+            <groupId>${project.groupId}</groupId>
+            <artifactId>wildfly-iiop-openjdk</artifactId>
+        </dependency>
+        <dependency>
+            <groupId>org.jboss.openjdk-orb</groupId>
+            <artifactId>openjdk-orb</artifactId>
+        </dependency>
+        <dependency>
+            <groupId>org.jboss</groupId>
+            <artifactId>jboss-transaction-spi-jakarta</artifactId>
+        </dependency>
+        <dependency>
+            <groupId>org.jboss.remoting</groupId>
+            <artifactId>jboss-remoting</artifactId>
+        </dependency>
+        <dependency>
+            <groupId>org.jboss.logging</groupId>
+            <artifactId>jboss-logging-annotations</artifactId>
+            <!-- This is a compile-time dependency of this project, but is not needed at compile or runtime by other
+                  projects that depend on this project.-->
+            <scope>provided</scope>
+            <optional>true</optional>
+        </dependency>
+        <dependency>
+            <groupId>org.jboss.logging</groupId>
+            <artifactId>jboss-logging-processor</artifactId>
+            <!-- This is a compile-time dependency of this project, but is not needed at compile or runtime by other
+                  projects that depend on this project.-->
+            <scope>provided</scope>
+            <optional>true</optional>
+        </dependency>
+        <dependency>
+          <groupId>jakarta.resource</groupId>
+          <artifactId>jakarta.resource-api</artifactId>
+        </dependency>
+        <dependency>
+          <groupId>jakarta.transaction</groupId>
+          <artifactId>jakarta.transaction-api</artifactId>
+        </dependency>
+        <dependency>
+            <groupId>org.wildfly.transaction</groupId>
+            <artifactId>wildfly-transaction-client-jakarta</artifactId>
+        </dependency>
+
+        <dependency>
+            <groupId>org.wildfly.wildfly-http-client</groupId>
+            <artifactId>wildfly-http-transaction-client</artifactId>
+        </dependency>
+
+        <dependency>
+            <groupId>org.wildfly.common</groupId>
+            <artifactId>wildfly-common</artifactId>
+        </dependency>
+        <dependency>
+            <groupId>org.wildfly.core</groupId>
+            <artifactId>wildfly-subsystem-test</artifactId>
+            <type>pom</type>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.wildfly.security</groupId>
+            <artifactId>wildfly-elytron-security-manager</artifactId>
+        </dependency>
+    </dependencies>


I also found some missing dependencies:

<dependency> <groupId>jakarta.enterprise.concurrent</groupId> <artifactId>jakarta.enterprise.concurrent-api</artifactId> </dependency> <dependency> <groupId>org.glassfish</groupId> <artifactId>jakarta.enterprise.concurrent</artifactId> </dependency> <dependency> <groupId>org.jboss.narayana.jts</groupId> <artifactId>narayana-jts-integration-jakarta</artifactId> </dependency> <dependency> <groupId>org.jboss.narayana.jts</groupId> <artifactId>narayana-jts-idlj-jakarta</artifactId> </dependency>

narayana-jts-integration-jakarta must be also added on the ee-9/pom.xml.

After adding them I'm able to compile and run the tests in that module.

As a final note, it would be desirable to keep these dependencies grouped by those which are Jakarta's native namespace and those that aren't. We have been doing the same for the other transformed modules. In general, it helps to see if we have something pending to upgrade on that module.

yersan · 2022-02-02T12:50:16Z

Superseded by #15171

This can be closed now.

mmusgrov · 2022-02-03T09:46:40Z

Superseded by #15171

github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Nov 29, 2021

yersan reviewed Nov 29, 2021

View reviewed changes

bstansberry added the EE9 label Nov 30, 2021

mmusgrov mentioned this pull request Dec 6, 2021

Upgrade Narayana to 5.12.4.Final #14974

Merged

darranl added the hold PR should not be merged for some reason. label Dec 6, 2021

tadamski mentioned this pull request Dec 10, 2021

[WFLY-15542] Connector subsystem Jakarta migration #15019

Merged

darranl added the rebase-this PR has a merge conflict. label Jan 10, 2022

mmusgrov force-pushed the WFLY-15548-and-WFLY-15446 branch 4 times, most recently from d08b5bd to 7953213 Compare January 24, 2022 12:42

yersan requested changes Jan 24, 2022

View reviewed changes

[WFLY-15548] [WFLY-15446] transaction subsystem: jakarta namespance p…

549f9ce

…review

mmusgrov force-pushed the WFLY-15548-and-WFLY-15446 branch from 7953213 to 549f9ce Compare January 24, 2022 14:37

yersan requested changes Jan 24, 2022

View reviewed changes

darranl removed the rebase-this PR has a merge conflict. label Jan 26, 2022

mmusgrov added 2 commits January 27, 2022 16:06

WFLY-15548-and-WFLY-15446 wip for pr 14975

c67c8fc

WFLY-15548 addressing pr review comments

3bf0a90

yersan mentioned this pull request Feb 1, 2022

[WFLY-15446][WFLY-15548][WFLY-15544] Move transaction subsystem to Jakarta native namespace #15171

Merged

mmusgrov closed this Feb 3, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WFLY-15548] [WFLY-15446] transaction subsystem: jakarta namespance p… #14975

[WFLY-15548] [WFLY-15446] transaction subsystem: jakarta namespance p… #14975

mmusgrov commented Nov 29, 2021 •

edited

yersan Nov 29, 2021

mmusgrov Nov 30, 2021

mmusgrov Dec 2, 2021

mmusgrov Jan 18, 2022

yersan Jan 18, 2022

mmusgrov Jan 21, 2022

yersan Jan 24, 2022

mmusgrov Jan 24, 2022

yersan Nov 29, 2021

darranl commented Dec 6, 2021

yersan Jan 24, 2022 •

edited

mmusgrov Jan 24, 2022

mmusgrov Jan 26, 2022

mmusgrov Jan 26, 2022

yersan Jan 26, 2022 •

edited

mmusgrov Jan 31, 2022

yersan Jan 24, 2022

yersan Jan 24, 2022 •

edited

yersan commented Feb 2, 2022

mmusgrov commented Feb 3, 2022

[WFLY-15548] [WFLY-15446] transaction subsystem: jakarta namespance p… #14975

[WFLY-15548] [WFLY-15446] transaction subsystem: jakarta namespance p… #14975

Conversation

mmusgrov commented Nov 29, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

darranl commented Dec 6, 2021

yersan Jan 24, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yersan Jan 26, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yersan Jan 24, 2022 • edited

Choose a reason for hiding this comment

yersan commented Feb 2, 2022

mmusgrov commented Feb 3, 2022

mmusgrov commented Nov 29, 2021 •

edited

yersan Jan 24, 2022 •

edited

yersan Jan 26, 2022 •

edited

yersan Jan 24, 2022 •

edited