[WFLY-15542] Connector subsystem Jakarta migration #15019

tadamski · 2021-12-10T20:33:39Z

https://issues.redhat.com/browse/WFLY-15542

Depends on:
#14975

yersan · 2021-12-13T09:42:11Z

ee-9/pom.xml

+            <dependency>
+                <groupId>jakarta.security.auth.message</groupId>
+                <artifactId>jakarta.security.auth.message-api</artifactId>
+                <version>${version.jakarta.security.auth.message-api}</version>
+                <exclusions>
+                    <exclusion>
+                        <groupId>*</groupId>
+                        <artifactId>*</artifactId>
+                    </exclusion>
+                </exclusions>
+            </dependency>


This dependency should be jakarta.authentication:jakarta.authentication-api:2.0.0 instead, which is already available in the pom, so I would not expect to introduce this variant (2.0.0-RC1) here.

fixed; I found out that this can be removed

darranl · 2021-12-16T13:30:00Z

ee-9/source-transform/connector/pom.xml

+        Maintain separation between the artifact id and the version to help prevent
+        merge conflicts between commits changing the GA and those changing the V.
+        -->
+        <version>26.0.0.Final-SNAPSHOT</version>


I think this will need updating to the current version in use on main.

darranl · 2022-01-07T14:00:20Z

@tadamski I think this one still needs some updates before we test again.

tadamski · 2022-01-07T22:50:42Z

@darranl I plan to fix and rebase this PR after transactions migration is merged.

bstansberry · 2022-02-04T03:25:15Z

@tadamski The transactions subsystem one is merged now.

tadamski · 2022-02-06T20:18:57Z

@bstansberry I have rebased and fixed the PR; should work fine now

yersan · 2022-02-07T11:43:14Z

ee-9/pom.xml

+            <dependency>
+                <groupId>org.jboss.ironjacamar</groupId>
+                <artifactId>ironjacamar-common-api-jakarta</artifactId>
+                <version>${version.org.jboss.ironjacamar}</version>
+                <exclusions>
+                    <exclusion>
+                        <groupId>*</groupId>
+                        <artifactId>*</artifactId>
+                    </exclusion>
+                </exclusions>
+            </dependency>
+
+            <dependency>
+                <groupId>org.jboss.ironjacamar</groupId>
+                <artifactId>ironjacamar-common-impl-jakarta</artifactId>
+                <version>${version.org.jboss.ironjacamar}</version>
+                <exclusions>
+                    <exclusion>
+                        <groupId>*</groupId>
+                        <artifactId>*</artifactId>
+                    </exclusion>
+                </exclusions>
+            </dependency>
+
+            <dependency>
+                <groupId>org.jboss.ironjacamar</groupId>
+                <artifactId>ironjacamar-common-spi-jakarta</artifactId>
+                <version>${version.org.jboss.ironjacamar}</version>
+                <exclusions>
+                    <exclusion>
+                        <groupId>*</groupId>
+                        <artifactId>*</artifactId>
+                    </exclusion>
+                </exclusions>
+            </dependency>
+
+            <dependency>
+                <groupId>org.jboss.ironjacamar</groupId>
+                <artifactId>ironjacamar-core-api-jakarta</artifactId>
+                <version>${version.org.jboss.ironjacamar}</version>
+                <exclusions>
+                    <exclusion>
+                        <groupId>*</groupId>
+                        <artifactId>*</artifactId>
+                    </exclusion>
+                </exclusions>
+            </dependency>
+
+            <dependency>
+                <groupId>org.jboss.ironjacamar</groupId>
+                <artifactId>ironjacamar-core-impl-jakarta</artifactId>
+                <version>${version.org.jboss.ironjacamar}</version>
+                <!--FIXME removing this results in NPE during compilation but I can't see any particular dependency blocked by the exclusion-->
+<!--                <exclusions>-->
+<!--                    <exclusion>-->
+<!--                        <groupId>*</groupId>-->
+<!--                        <artifactId>*</artifactId>-->
+<!--                    </exclusion>-->
+<!--                </exclusions>-->
+            </dependency>
+
+            <dependency>
+                <groupId>org.jboss.ironjacamar</groupId>
+                <artifactId>ironjacamar-deployers-common-jakarta</artifactId>
+                <version>${version.org.jboss.ironjacamar}</version>
+                <exclusions>
+                    <exclusion>
+                        <groupId>*</groupId>
+                        <artifactId>*</artifactId>
+                    </exclusion>
+                </exclusions>
+            </dependency>
+
+            <dependency>
+                <groupId>org.jboss.ironjacamar</groupId>
+                <artifactId>ironjacamar-jdbc-jakarta</artifactId>
+                <version>${version.org.jboss.ironjacamar}</version>
+                <exclusions>
+                    <exclusion>
+                        <groupId>*</groupId>
+                        <artifactId>*</artifactId>
+                    </exclusion>
+                </exclusions>
+            </dependency>
+
+            <dependency>
+                <groupId>org.jboss.ironjacamar</groupId>
+                <artifactId>ironjacamar-validator-jakarta</artifactId>
+                <version>${version.org.jboss.ironjacamar}</version>
+                <exclusions>
+                    <exclusion>
+                        <groupId>*</groupId>
+                        <artifactId>*</artifactId>
+                    </exclusion>
+                </exclusions>
+            </dependency>


For any dependency added here that is in the Jakarta name space, you have to exclude the non-jakarta one on the ee-9/feature-pack module from the Galleon feature pack that is pulling it. Besides avoiding the pollution of the classpath, that will prevent getting it transformed unnecessarily. An example:

wildfly/ee-9/feature-pack/pom.xml

Lines 810 to 813 in 169b85c

<exclusion>

<groupId>org.jboss.narayana.jts</groupId>

<artifactId>narayana-jts-integration</artifactId>

</exclusion>

Then you need to enable the JBoss Modules module for such a dependency to use the -jarkarta suffix, for example:

wildfly/ee-feature-pack/common/src/main/resources/modules/system/layers/base/org/jboss/jts/integration/main/module.xml

Line 32 in fc5a1fa

<artifact name="\${org.jboss.narayana.jts:narayana-jts-integration@module.jakarta.suffix@}"/>

Then you probably will need to add the license file for the -jakarta one, for example:

wildfly/ee-9/common/src/main/resources/license/preview-feature-pack-common-licenses.xml

Lines 114 to 125 in 5043f7d

<dependency>

<groupId>org.jboss.narayana.jts</groupId>

<artifactId>narayana-jts-integration-jakarta</artifactId>

<licenses>

<license>

<name>GNU Lesser General Public License v2.1 only</name>

<url>http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html</url>

<distribution>repo</distribution>

</license>

</licenses>

</dependency>

<dependency>

And finally, in order to get it processed correctly by Galleon, you will need to add the -jakarta one to the ee-9/common module, for example:

wildfly/ee-9/common/pom.xml

Lines 380 to 389 in 5043f7d

<dependency>

<groupId>org.jboss.narayana.jts</groupId>

<artifactId>narayana-jts-integration-jakarta</artifactId>

<exclusions>

<exclusion>

<groupId>*</groupId>

<artifactId>*</artifactId>

</exclusion>

</exclusions>

</dependency>

yersan · 2022-02-07T11:58:03Z

ee-9/pom.xml

+                <!--FIXME removing this results in NPE during compilation but I can't see any particular dependency blocked by the exclusion-->
+<!--                <exclusions>-->
+<!--                    <exclusion>-->
+<!--                        <groupId>*</groupId>-->
+<!--                        <artifactId>*</artifactId>-->
+<!--                    </exclusion>-->
+<!--                </exclusions>-->


Following the same pattern, we have to exclude all the transitive dependencies. After doing it, you have to check your wildfly-connector-jakarta and add there all the dependencies needed to get your module compiled.

You are getting NPE during the compilation because you are missing dependencies brought in transitively by this module. You will need to review them and add them to your wildfly-connector-jakarta module.

yersan · 2022-02-07T11:58:38Z

ee-9/pom.xml

+<!--                <exclusions>-->
+<!--                    <exclusion>-->
+<!--                        <groupId>*</groupId>-->
+<!--                        <artifactId>*</artifactId>-->
+<!--                    </exclusion>-->
+<!--                </exclusions>-->


Following the same pattern, we have to exclude all the transitive dependencies. After doing it, you have to check your wildfly-connector-jakarta and add there all the dependencies needed to get your module compiled.

You are getting NPE during the compilation because you are missing dependencies brought in transitively by this module. You will need to review them and add them to your wildfly-connector-jakarta module.

yersan · 2022-02-07T12:09:10Z

ee-9/source-transform/connector/pom.xml

+        <relativePath>../pom.xml</relativePath>
+    </parent>
+
+    <artifactId>wildfly-connector-jakarta</artifactId>


In addition to the other -jakarta dependencies added to ee-9/pom.xml, you will need to exclude the old one (wildfly-connector) from the Galleon Pack that is pulling it on the ee-9/feature-pack module, modify its JBoss Module module to enable the -jarkarta suffix, and review the license file.

tadamski · 2022-02-15T13:42:03Z

@yersan thanks for all the feedback - I have fixed the problems that you mentioned above

@fjuma @darranl IronJacamar still relies on PicketBox. Because of that, I had to temporary restore PicketBox dependency to make ee-9 connector compile:
tadamski@8cd9981#diff-31d9e3bb0671159c056658b3acb69396cbcf1a43a00db007c39c99817177c190R262

there is a integration layer that I think should be migrated to Elytron:
https://github.com/ironjacamar/ironjacamar/tree/main/core/impl/src/main/java/org/jboss/jca/core/security/picketbox

I have created https://issues.redhat.com/browse/JBJCA-1441 to deal with this issue.

The question is whether it should be implemented before this PR is fixed. For now, I have updated the branch so that it can be merged before the fix.

yersan · 2022-02-16T10:32:24Z

ee-9/feature-pack/pom.xml

+                <exclusion>
+                    <groupId>org.jboss.ironjacamar</groupId>
+                    <artifactId>ironjacamar-common-impl-jakarta</artifactId>
+                </exclusion>


Hi @tadamski , you have to exclude the old non -jakarta versions from this feature pack.

hi @yersan, fixed

bstansberry · 2022-02-16T21:18:00Z

ee-9/pom.xml

+                        <artifactId>*</artifactId>
+                    </exclusion>
+                </exclusions>
+            </dependency>


This dependency no longer exists.

bstansberry · 2022-02-21T21:38:11Z

Thanks @tadamski! :) And @yersan for the review

github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Dec 10, 2021

yersan requested changes Dec 13, 2021

View reviewed changes

darranl reviewed Dec 16, 2021

View reviewed changes

darranl added the EE9 label Jan 12, 2022

tadamski force-pushed the WFLY-15542 branch from fa5422f to c408175 Compare February 6, 2022 20:18

yersan requested changes Feb 7, 2022

View reviewed changes

tadamski force-pushed the WFLY-15542 branch 3 times, most recently from ce54185 to 8cd9981 Compare February 15, 2022 13:22

yersan requested changes Feb 16, 2022

View reviewed changes

[WFLY-15825] Upgrade ironjacamar to 1.5.5.Final

c42ce7c

tadamski force-pushed the WFLY-15542 branch from 8cd9981 to fde0062 Compare February 16, 2022 18:26

bstansberry reviewed Feb 16, 2022

View reviewed changes

[WFLY-15542] Connector subsystem Jakarta migration

74d7926

tadamski force-pushed the WFLY-15542 branch from fde0062 to 74d7926 Compare February 16, 2022 22:19

bstansberry approved these changes Feb 21, 2022

View reviewed changes

bstansberry merged commit b3c7296 into wildfly:main Feb 21, 2022

tadamski deleted the WFLY-15542 branch July 6, 2022 12:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WFLY-15542] Connector subsystem Jakarta migration #15019

[WFLY-15542] Connector subsystem Jakarta migration #15019

tadamski commented Dec 10, 2021

yersan Dec 13, 2021

tadamski Feb 6, 2022

darranl Dec 16, 2021

tadamski Feb 6, 2022

darranl commented Jan 7, 2022

tadamski commented Jan 7, 2022

bstansberry commented Feb 4, 2022

tadamski commented Feb 6, 2022

yersan Feb 7, 2022

tadamski Feb 11, 2022

yersan Feb 7, 2022

tadamski Feb 11, 2022

yersan Feb 7, 2022

tadamski Feb 11, 2022

yersan Feb 7, 2022

tadamski Feb 15, 2022

tadamski commented Feb 15, 2022

yersan Feb 16, 2022

tadamski Feb 16, 2022

bstansberry Feb 16, 2022

tadamski Feb 16, 2022

bstansberry commented Feb 21, 2022

	<exclusion>
	<groupId>org.jboss.narayana.jts</groupId>
	<artifactId>narayana-jts-integration</artifactId>
	</exclusion>

	<dependency>
	<groupId>org.jboss.narayana.jts</groupId>
	<artifactId>narayana-jts-integration-jakarta</artifactId>
	<licenses>
	<license>
	<name>GNU Lesser General Public License v2.1 only</name>
	<url>http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html</url>
	<distribution>repo</distribution>
	</license>
	</licenses>
	</dependency>
	<dependency>

[WFLY-15542] Connector subsystem Jakarta migration #15019

[WFLY-15542] Connector subsystem Jakarta migration #15019

Conversation

tadamski commented Dec 10, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

darranl commented Jan 7, 2022

tadamski commented Jan 7, 2022

bstansberry commented Feb 4, 2022

tadamski commented Feb 6, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tadamski commented Feb 15, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bstansberry commented Feb 21, 2022