Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WFLY-15891 Duplicate dayOfWeek mapping in ejb3 DayOfWeek and DayOfMon… #15125

Merged
merged 1 commit into from Mar 1, 2022
Merged

WFLY-15891 Duplicate dayOfWeek mapping in ejb3 DayOfWeek and DayOfMon… #15125

merged 1 commit into from Mar 1, 2022

Conversation

chengfang
Copy link
Contributor

…th classes

https://issues.redhat.com/browse/WFLY-15891

This PR makes ejb3 DayOfWeek and DayOfMonth classes share the same DayOfWeek.DAY_OF_WEEK_ALIAS mapping, and remove the one in DayOfMonth class.

And some general cleanup.

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Jan 18, 2022
@chengfang
Copy link
Contributor Author

@tadamski please review.

@chengfang chengfang mentioned this pull request Jan 27, 2022
Merged
@pferraro
Copy link
Contributor

@chengfang This needs a rebase.

@chengfang
Copy link
Contributor Author

Rebased and all conflicts resolved.

@chengfang
Copy link
Contributor Author

/retest

@bstansberry bstansberry merged commit 5c2f0f7 into wildfly:main Mar 1, 2022
@chengfang chengfang deleted the DayOfWeek-dup-WFLY-15891 branch March 21, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bstansberry bstansberry bstansberry approved these changes

Assignees
No one assigned
Labels
deps-ok Dependencies have been checked, and there are no significant changes
Projects
None yet
Milestone
No milestone
3 participants
@chengfang @pferraro @bstansberry