WFLY-15963 Combine ORDINALS and ORDINAL_TO_WEEK_NUMBER_MAPPING fields… #15146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
deps-ok
… in ejb3 DayOfMonth class cleanup (improve the use of toLowerCase and equalsIgnoreCase; remove unnecessary null check)
chengfang
force-pushed
the
ordinal-week-number-WFLY-15963
branch
from
a0f44cc
to
daef72d
Compare
|
@tadamski please review. |
|
This PR follows on #15125, but both PR are indepent of each other. There will be conflict once one is merged, and need manual resolution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… in ejb3 DayOfMonth class
cleanup (improve the use of toLowerCase and equalsIgnoreCase; remove unnecessary null check)
https://issues.redhat.com/browse/WFLY-15963
some notes about changes of code cleanup:
Pattern "\\s+"is moved to the class-level to avoid compiling the pattern for every invocation of the method.isDayOfWeekBasedmethod is renamed tosplitDayOfWeekBasedand the return type is changed frombooleantoString[]. This method splits the input string to do the checking, and the caller of this method also needs to split the data. To avoid splitting it twice, this method is changed to return the split result: a non-null value is equivalent to previous true return value; a null is equivalent to the previous false return value.