WFLY-18069 Eliminate unnecessary buffer copies when writing an object with known size via ProtoStream #16903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
deps-ok
|
/retest |
|
Triggered a CI run as I just merged three PRs - if this is reviewed (and still passes) it can likely go straight in as nothing to aggregate with. |
rhusar
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WFLY-18069
Uses non-buffering encoder during marshalling whenever possible, e.g. the backing OutputStream is a ByteArrayOutputStream.
Relocates reference tracking logic from the AnyMarshaller to the ProtoStreamWriter.writeAny(...) and ProtoStreamReader.readAny() method implementations.
Replaces thread local based context propagation during read/write/size operations with per-operation context instances.
Adds per-operation buffer size caching to reduce heap/cpu usage during a write operation.