Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFLY-18348] PermissionUtils should delegate to the WildFly Core variant where possible #17128

Merged
merged 1 commit into from
Sep 18, 2023
Merged

[WFLY-18348] PermissionUtils should delegate to the WildFly Core variant where possible #17128

merged 1 commit into from
Sep 18, 2023

Conversation

lvydra
Copy link
Contributor

@lvydra lvydra commented Aug 23, 2023

@wildfly-bot
Copy link

wildfly-bot bot commented Aug 23, 2023

/cc @pferraro, @fjuma, @rhusar, @yersan, @chengfang, @jimma, @mmusgrov

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Aug 23, 2023
rhusar
rhusar suggested changes Aug 29, 2023
View reviewed changes
Copy link
Member

@rhusar rhusar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This creates a lot of failures triggered by Caused by: java.lang.NoClassDefFoundError: nu/xom/Node since clearly org.jboss.as.test.shared.PermissionUtils is still relying on xom.

@lvydra
Copy link
Contributor Author

lvydra commented Aug 30, 2023

Hi @rhusar , thank you for your comment. It seems that the problem is in wildfly-core dependency not yet including changes done in the https://issues.redhat.com/browse/WFCORE-6461.

@bstansberry
Copy link
Contributor

/retest

@bstansberry bstansberry added the core-upgrade-needed PR requires a wildfly-core change to be merged and integrated first label Sep 6, 2023
@bstansberry
Copy link
Contributor

When I merged the WFCORE-6461 fix I set the wrong Fix Version. So it's not yet in the core release the WF uses.

@bstansberry
Copy link
Contributor

/retest

@bstansberry bstansberry removed the core-upgrade-needed PR requires a wildfly-core change to be merged and integrated first label Sep 14, 2023
@bstansberry bstansberry mentioned this pull request Sep 14, 2023
Closed
@bstansberry bstansberry merged commit 6434f52 into wildfly:main Sep 18, 2023
15 checks passed
@bstansberry
Copy link
Contributor

Thanks @lvydra!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhusar rhusar rhusar requested changes

@bstansberry bstansberry bstansberry approved these changes

Assignees
No one assigned
Labels
deps-ok Dependencies have been checked, and there are no significant changes
Projects
None yet
Milestone
No milestone
3 participants
@lvydra @bstansberry @rhusar