[WFLY-19286] Add ServerSetupTasks to reload server to a desired stabi… #17849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kabir
force-pushed
the
WFLY-19286-reload-stability-level-tasks
branch
2 times, most recently
from
c218b18
to
013ae74
Compare
jamezp
reviewed
May 7, 2024
| } | ||
|
|
||
| @Override | ||
| public void tearDown(ManagementClient managementClient, String containerId) throws Exception { |
There was a problem hiding this comment.
Should this be a final method with a doTearDown() to ensure the snapshot is always restored?
kabir
force-pushed
the
WFLY-19286-reload-stability-level-tasks
branch
from
013ae74
to
0a88d1d
Compare
|
@jamezp fixed (sorry for the delay) |
github-actions
bot
added
the
deps-ok
bstansberry
requested changes
May 16, 2024
There was a problem hiding this comment.
@kabir In general this LGTM to me but...
- I have some minor comments
- Please rebase as this branch now has two unrelated commits that have equivalents that are already in main.
Please feel free to merge this when ready; i.e. don't wait for my formal approval of the above as I'll not be around for a while.
| import org.junit.Assert; | ||
| import org.junit.Test; | ||
|
|
||
| import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.CORE_SERVICE; |
| import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.RELOAD_ENHANCED; | ||
| import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.STABILITY; | ||
| import static org.jboss.as.server.controller.descriptions.ServerDescriptionConstants.SERVER_ENVIRONMENT; | ||
| import static org.junit.Assert.fail; |
|
|
||
| import java.io.File; | ||
| import java.util.HashSet; | ||
| import java.util.Set; |
There was a problem hiding this comment.
java and javax after statics but before others
| * Once the test is done, the original stability level is restored. | ||
| * | ||
| * In order to not pollute the configuration with XML from a different stability level following the run of the test, | ||
| * it takes a snapshot of the server configuration in the setup() method, and |
| // Make sure the desired stability level is one of the ones supported by the server | ||
| Set<Stability> supportedStabilityLevels = getSupportedStabilityLevels(managementClient); | ||
| Assume.assumeTrue( | ||
| String.format("%s is not a supported stability level", desiredStability, supportedStabilityLevels), |
There was a problem hiding this comment.
This is not a valid statement -- two vars but only one expression in the format string
| node.get(ModelDescriptionConstants.OP).set("take-snapshot"); | ||
| ModelNode result = client.getControllerClient().execute(node); | ||
| if (!"success".equals(result.get(ClientConstants.OUTCOME).asString())) { | ||
| fail("Reload operation didn't finish successfully: " + result.asString()); |
There was a problem hiding this comment.
s/Reload/take-snapshot
…config might be incompatible with the higher one
kabir
force-pushed
the
WFLY-19286-reload-stability-level-tasks
branch
from
0a88d1d
to
60ce0bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lity level
https://issues.redhat.com/browse/WFLY-19286
This needs the Arquillian upgrade in #17832 merged before the tests can pass
More information about the wildfly-bot[bot]