[WFLY-19298] Update fasterxml to 2.17.0

[spyrkob]

Issue: https://issues.redhat.com/browse/WFLY-19298

---

More information about the wildfly-bot[bot]

[bstansberry]

This requires approval from the various leads responsible for FasterXML use:

@jamezp (RESTEasy)
@rhusar (com.microsoft.azure.storage module)
@yrodiere (Hibernate Search stuff)
@scottmarlow (Hibernate ORM)
@fjuma (org.wildfly.security.elytron-http-oidc and org.wildfly.security.elytron-jose-*)
@jasondlee (OpenTelemetry)
@pferraro (OpenAPI)
@kabir (VertX and Kafka)

[scottmarlow]

Hibernate ORM 6.4.4.Final is currently using 2.14.1 as is the ORM main branch.

Let's see what @yrodiere has to say about Search but I think 7.1.0.Final is on 2.15.2 and main looks to be on 2.17.0.

I think the underlying question is whether there could be Search/ORM releases on fasterxml 2.17.0 if that could work for some future versions of all components?

[fjuma]

Thanks @spyrkob!

[yrodiere]

Hibernate ORM 6.4.4.Final is currently using 2.14.1 as is the ORM main branch.

WildFly should probably upgrade to ORM 6.5 though, and that's not the main branch. Did you have a look at ORM 6.5?
EDIT: Well that was a dumb suggestion, sorry. If main is on 2.14.1, 6.5 probably is too.

Let's see what @yrodiere has to say about Search but I think 7.1.0.Final is on 2.15.2 and main looks to be on 2.17.0.

I'll defer to @marko-bekhta for Search.

I think the underlying question is whether there could be Search/ORM releases on fasterxml 2.17.0 if that could work for some future versions of all components?

We could upgrade in ORM 6.6, sure, though obviously that'll take a few weeks/months to reach WildFly.

We need to have a look, though. I suspect ORM is not actually that deeply coupled with Jackson, at least if it's only about JSON columns, but I might be missing something. If coupling is indeed loose, it might be enough to just run the ORM test suite with the dependency upgraded.

@sebersole or @beikov may have an answer ready for you, otherwise I'll have a closer look, but not before next week unfortunately.

[beikov]

I suspect ORM is not actually that deeply coupled with Jackson, at least if it's only about JSON columns, but I might be missing something. If coupling is indeed loose, it might be enough to just run the ORM test suite with the dependency upgraded.

You're right, it's an "optional" dependency. Upgrading Jackson should not be a problem, so +1 from my side on upgrading in Wildfly.

[scottmarlow]

I suspect ORM is not actually that deeply coupled with Jackson, at least if it's only about JSON columns, but I might be missing something. If coupling is indeed loose, it might be enough to just run the ORM test suite with the dependency upgraded.

You're right, it's an "optional" dependency. Upgrading Jackson should not be a problem, so +1 from my side on upgrading in Wildfly.

Optional dependencies or not, I think the Hibernate ORM testsuite needs to pass with the fasterxml upgrade before WildFly upgrades to it to ensure that the ORM integration fasterxml works as expected.

[rhusar]

Fine for com.microsoft.azure.storage module. 👍🏼

[marko-bekhta]

For Hibernate Search:

• 7.2 (currently in development) Jackson was upgraded to 2.17 a while ago in https://hibernate.atlassian.net/browse/HSEARCH-5106
• 7.1 build passes with 2.17.0: [DO NOT MERGE] Test upgrade to Jackson 2.17.0 in 7.1 hibernate/hibernate-search#4141

[yrodiere]

Thanks @marko-bekhta @beikov @scottmarlow .

I created:

• https://hibernate.atlassian.net/browse/HHH-18050 to upgrade to Jackson 2.17.0 in Hibernate ORM 6.6 (+ corresponding PR)
• [DO NOT MERGE] For testing only: Backport HHH-18050 to branch 6.5 - Upgrade to Jackson 2.17.0 hibernate/hibernate-orm#8284 to test Hibernate ORM 6.5 against Jackson 2.17.0 (we won't merge this PR, it's just for testing purposes)

@scottmarlow Will you please make the upgrade to Hibernate ORM 6.5 in WildFly?

[beikov]

It's a good first step for Wildfly to try out ORM 6.5, but I would like to ask you to make sure that version doesn't end up in a release, because ORM 6.6 is around the corner and it would be best for Wildfly to use that ORM version in its next release.

[yrodiere]

It's a good first step for Wildfly to try out ORM 6.5, but I would like to ask you to make sure that version doesn't end up in a release, because ORM 6.6 is around the corner and it would be best for Wildfly to use that ORM version in its next release.

Clarifying: ideally WildFly's next version would use Hibernate ORM 6.6 if it's ready by the feature freeze date, but failing that shipping Hibernate ORM 6.5 would definitely be better than the current Hibernate ORM 6.4. So yes, please upgrade @scottmarlow :)

We're going on a tangent here though, let's move to Zulip if more discussion is necessary.

Back to discussing Jackson here :)

[yrodiere]

Hibernate ORM 6.5 works fine with Jackson 2.17: hibernate/hibernate-orm#8284
I'll leave it to @scottmarlow to upgrade to Hibernate ORM 6.5 in WildFly, as WildFly is currently using Hibernate ORM 6.4 (but shouldn't).

[scottmarlow]

Hibernate ORM 6.5 works fine with Jackson 2.17: hibernate/hibernate-orm#8284 I'll leave it to @scottmarlow to upgrade to Hibernate ORM 6.5 in WildFly, as WildFly is currently using Hibernate ORM 6.4 (but shouldn't).

Created https://issues.redhat.com/browse/WFLY-19306 for trying to upgrade to ORM 6.5 in WildFly (note that WildFly Preview is already including ORM 6.5).

[jamezp]

There is an issue with RESTEasy with this upgrade. Previously java.util.Optional would serialize to something like:

{"empty":false,"present":true}

This happened when the com.fasterxml.jackson.datatype.jdk8.Jdk8Module was not registered with the ObjectMapper. In 2.17 this now throws an exception instead because the Jdk8Module is not installed by default. It could be related to FasterXML/jackson-modules-java8#294.

One could argue that RESTEasy should register some default modules in a default ObjectMapper. However, there could be users relying on this old behavior. IMO the old behavior is wrong, but I'll need to make changes in RESTEasy to fix the support for this. If we feel this is needed please let me know so we can file an issue and fix this.

[jamezp]

I've filed RESTEASY-3502 for the RESTEasy issue. I can disable the tests that fail in RESTEasy if a newer version of Jackson is found. However, this could be considered a behavior change and if we proceed with the upgrade we should document that.