Initial remoting via HTTP upgrade support #4447
Conversation
|
Triggering build using a merge of 2b53ae84491cf304507638688566ee2f030456a5 on branch master: |
|
Build 6946 is now running using a merge of 2b53ae84491cf304507638688566ee2f030456a5 on branch master: |
|
Build 6946 outcome was ABORTED using a merge of 2b53ae84491cf304507638688566ee2f030456a5 on branch master: |
|
Triggering build using a merge of 1ea26b20c48ef53cfa3ca55eb5258654930f20e4 on branch master: |
|
Build 6947 is now running using a merge of 1ea26b20c48ef53cfa3ca55eb5258654930f20e4 on branch master: |
|
Build 6947 outcome was ABORTED using a merge of 1ea26b20c48ef53cfa3ca55eb5258654930f20e4 on branch master: |
|
retest this please |
|
Triggering build using a merge of 1ea26b20c48ef53cfa3ca55eb5258654930f20e4 on branch master: |
|
Build 6948 is now running using a merge of 1ea26b20c48ef53cfa3ca55eb5258654930f20e4 on branch master: |
|
Build 6948 outcome was ABORTED using a merge of 1ea26b20c48ef53cfa3ca55eb5258654930f20e4 on branch master: |
|
Triggering build using a merge of 12017f0dc2f4620fbc2869498fd286bb1e110fe6 on branch master: |
|
Build 6951 is now running using a merge of 12017f0dc2f4620fbc2869498fd286bb1e110fe6 on branch master: |
|
Build 6951 outcome was SUCCESS using a merge of 12017f0dc2f4620fbc2869498fd286bb1e110fe6 on branch master: |
|
Why change the default and break things like JBDS? IMO we should wait until we have worked out how they will adapt. |
|
Because otherwise you cannot connect to a default server using the default settings, as the remoting port is not open by default. One option would be to leave the remoting port in our default configs, but that kind of defeats the purpose as we are trying to reduce our out of the box port usage. We could do it temporarily for now until JBDS has time to adjust though? |
|
Yes, I think we should do it temporarily. This is just MHO, but I think reducing our out-of-the-box port usage is more of a secondary goal. The key thing is users being able to reduce port usage if desired. Obviously we don't want to use more ports than is necessary. It IS important that JBDS adapts to this though, as they'll want to be able to work with WF instances in constrained environments like OpenShift that will certainly configure the minimum number of ports. So, +1 to eventually changing the default. |
|
So maybe I should change default config to still open a remoting port for now, then remove it again after Alpha1, so there is always a released version of the client that is compatible with wildfly? My thoughts were that it would be better to just make the change and force clients to deal with it, otherwise there will likely always be something that we are keeping the remoting port in the default config for. |
|
I pinged Max Andersen and Rob Stryker to be sure they are aware of this coming change. The "remove after Alpha1" approach sounds reasonable. |
This commit adds support for multiplexing the remoting protocol over the HTTP management port, removing the need for two seperate management ports. Port 9999 is now no longer present in the default config, and the management client will attempt to connect via a HTTP upgrade by default.
|
Triggering build using a merge of 1db0f2eeae0d096e3510c3a702b67a5d58855aa3 on branch master: |
|
Build 7053 is now running using a merge of 1db0f2eeae0d096e3510c3a702b67a5d58855aa3 on branch master: |
|
Build 7053 outcome was FAILURE using a merge of 1db0f2eeae0d096e3510c3a702b67a5d58855aa3 on branch master: |
|
Triggering build using a merge of 637aa537b22bddfa89e03cc810a1cd00a08d5a26 on branch master: |
|
Triggering build using a merge of 9357982147760ceb6417a2966a919f685b6679db on branch master: |
|
Build 7055 is now running using a merge of 9357982147760ceb6417a2966a919f685b6679db on branch master: |
|
Build 7055 outcome was FAILURE using a merge of 9357982147760ceb6417a2966a919f685b6679db on branch master: |
|
Triggering build using a merge of 730949e on branch master: |
|
Build 7056 is now running using a merge of 730949e on branch master: |
|
Build 7056 outcome was SUCCESS using a merge of 730949e on branch master: |
|
I have modified this so the default config still has port 9999 open. |
|
merging |
|
merged |
This commit adds support for multiplexing remoting over the
management HTTP server port. By default the management
remoting port will no longer be availble, which will
break out of the box compatibility with older clients.
This commit does not address the remoting subsystem
endpoint used by EJB and remoting naming. This will be
added in a later commit.