-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFLY-410] Custom stack resource for JGroups #4796
Conversation
Build 151 is now running using a merge of 9d999dfc8d31a4451e238d736c6070394eb982e6 |
Build 151 outcome was SUCCESS using a merge of 9d999dfc8d31a4451e238d736c6070394eb982e6 |
Just going to trigger a run to see if this is still mergeable. retest this please. |
Build 364 is now running using a merge of 9d999dfc8d31a4451e238d736c6070394eb982e6 |
Build 364 outcome was FAILURE using a merge of 9d999dfc8d31a4451e238d736c6070394eb982e6 |
Re-based against master and running again. |
@@ -0,0 +1,130 @@ | |||
package org.jboss.as.clustering.jgroups.subsystem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing copyright header.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
I think this will break in a managed domain because when a slave HC registers it gets shipped the domain config from the master as a List and then the slave HC converts those into Resources. And a standard Resource impl is used, so your custom resource will be lost. The slave HC uses custom Resource impls it knows about, but it has no way to know about subsystem resource impls. This is a general issue with domain mode that I hope to address in the next week or so. A fix is needed for the blocker RBAC feature so it has to happen. So I prefer to hold off on merging this until that's in. Sorry for not thinking of this before. |
No problem on the delay. I have more custom resources besides this one :-) |
This has been around for a while. Just triggering a run to see if this needs a rebase. retest this please |
This PR has been languishing for 3 months ... can we get it merged? |
I have to write the thing to let it work in a managed domain. :( I'm still stuck in EAP 6.2 mode. |
Argh! My fault - I now see the comment above which I remember reading but just forgot about! |
Nah; I wanted to get that done a long time ago. Unfortunately the easy solution I had in mind was bogus so now I need to do it properly. |
Closing this, as Paul went another way with #6992. Sorry it's taken so long to get the domain mode thing that was blocking this done. |
This PR does the following: