WFLY-2404 Port SingleSignOn Valve to Undertow auth mechanism #5882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build 2593 is now running using a merge of c38ba8f |
|
Build 2593 outcome was FAILURE using a merge of c38ba8f Build problems:Failed tests detected Failed tests |
|
retest this please ClusteredSingleSignOnTestCase failures seem valid... |
|
Build 2594 is now running using a merge of c38ba8f |
|
Build 2594 outcome was FAILURE using a merge of c38ba8f Build problems:Failed tests detected Failed tests |
|
This is just a problem with the domain of the cookie in the test (I naively assumed a domain of 127.0.0.1). I'll have a fix shortly. |
|
Build 2598 is now running using a merge of 29bd7d5 |
|
FYI - Stuart has added a new SingleSignOnAuthenticationMechanism to undertow-servlet, which will make the one included in this PR obsolete. Don't merge this until the Undertow 1.0.0.Final release is merged and I update this PR. |
|
Build 2599 is now running using a merge of 43c0e91 |
|
Build 2598 outcome was FAILURE using a merge of 43c0e91 Build problems:Failed tests detected Failed tests |
|
Build 2599 outcome was FAILURE using a merge of 43c0e91 Build problems:Failed tests detected Failed tests |
| } | ||
|
|
||
| @Override | ||
| public void stop(StopContext stopContext) { |
There was a problem hiding this comment.
Should this do a host.getValue().unregisterAdditionalAuthenticationMechanism("sso")?
Even if the answer is yes, I don't think this should block getting this in if all else is ok.
There was a problem hiding this comment.
There is no corresponding Host.unregisterAdditionalAuthenticationMechanism(...) method. Perhaps there should be?
There was a problem hiding this comment.
Yeah - there really should be. Someone can add/remove the sso resource independently from the host. I'll add this method.
There was a problem hiding this comment.
Yeah, good point, I forgot about that in hurry to get it done in time :(
|
I haven't looked at all the runtime service parts of this patch, but FWIW the management stuff looks fine. |
|
Build 2600 is now running using a merge of 088a50c |
…spi/infinispan modules. Implement distributable SSO support for Undertow.
Use a constant for single-sign-on resource/path. Add Lifecycle support to SingleSignOnManager. Create SingleSignOnManagerService that properly invokes the lifecycle methods of the SingleSignOnManager. Integrate support for distributable SingleSignOnManager.
|
Build 2601 is now running using a merge of 852d68b |
|
Build 2602 is now running using a merge of c6f583f |
|
Build 2600 outcome was FAILURE using a merge of c6f583f Build problems:Failed tests detected Failed tests |
|
Build 2601 outcome was FAILURE using a merge of 2ea518b Build problems:Failed tests detected Failed tests |
|
Build 2604 is now running using a merge of 2ea518b |
|
Build 2602 outcome was FAILURE using a merge of 3f47de8 Build problems:Failed tests detected Failed tests |
|
Build 2605 is now running using a merge of 3f47de8 |
|
Build 2604 outcome was FAILURE using a merge of 3f47de8 Build problems:Failed tests detected Failed tests |
|
Build 2605 outcome was SUCCESS using a merge of 3f47de8 |
|
Hooray! |
|
Rebased cr5 version merged instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/WFLY-2404
This PR includes both distributable and non-distributable support.
I've also re-enabled the clustered sso integration test.