Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-2879] - Remove duplicated code from test cases where custom module... #6658

Merged
merged 2 commits into from
Sep 3, 2014

Conversation

kabir
Copy link
Contributor

@kabir kabir commented Sep 2, 2014

...s are needed.

This was originally #6577 but it appears that got closed rather than merged. I noticed this when doing https://github.com/jbossas/jboss-eap/pull/1629 which then showed that this work was not part of upstream.

The TempTestModule class needs to be removed once wildfly/wildfly-core#151 has been released, and updated to use TestModule from wildfly-core. https://issues.jboss.org/browse/WFLY-3807 is there to make sure this does not get forgotten.

@wildfly-ci
Copy link

Linux Build 4688 is now running using a merge of 0109206

@wildfly-ci
Copy link

Linux Build 4688 outcome was FAILURE using a merge of 0109206
Summary: Tests failed: 2 (2 new), passed: 2929, ignored: 248 Build time: 0:59:38

Build problems:

Failed tests detected
Process exited with code 1

Failed tests

org.jboss.as.test.integration.weld.modules.access.BuiltInBeanWithPackagePrivateConstructorTest: java.lang.RuntimeException: Could not invoke deployment method: public static org.jboss.shrinkwrap.api.Archive org.jboss.as.test.integration.weld.modules.access.BuiltInBeanWithPackagePrivateConstructorTest.getDeployment() throws java.lang.Exception
    at org.jboss.as.test.integration.weld.modules.access.BuiltInBeanWithPackagePrivateConstructorTest.tearDown(BuiltInBeanWithPackagePrivateConstructorTest.java:55)
    at org.jboss.as.test.integration.weld.modules.access.BuiltInBeanWithPackagePrivateConstructorTest.doSetup(BuiltInBeanWithPackagePrivateConstructorTest.java:49)

org.jboss.as.test.integration.weld.modules.access.BuiltInBeanWithPackagePrivateConstructorTest: java.lang.NullPointerException: null
    at org.jboss.as.test.integration.weld.modules.access.BuiltInBeanWithPackagePrivateConstructorTest.tearDown(BuiltInBeanWithPackagePrivateConstructorTest.java:55)

@wildfly-ci
Copy link

Linux Build 4689 is now running using a merge of 4a395b0

@wildfly-ci
Copy link

Linux Build 4689 outcome was FAILURE using a merge of 4a395b0
Summary: Tests failed: 1 (1 new), passed: 2929, ignored: 248 Build time: 1:00:23

Build problems:

Failed tests detected
Process exited with code 1

Failed tests

org.jboss.as.test.integration.weld.modules.access.BuiltInBeanWithPackagePrivateConstructorTest.testBeanInjectable: java.lang.NoClassDefFoundError: Lorg/jboss/as/test/module/util/TestModule;
    at java.lang.Class.getDeclaredFields0(Native Method)
    at java.lang.Class.privateGetDeclaredFields(Class.java:2397)

@@ -46,15 +43,18 @@

@Inject
private InjectedBean injectedBean;
private static TestModule testModule;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to also package this class up in the test archive

@kabir kabir added the hold label Sep 3, 2014
…nce TestModule is available in the next wildfly-core release
@wildfly-ci
Copy link

Linux Build 4705 is now running using a merge of 952008b

@wildfly-ci
Copy link

Linux Build 4706 is now running using a merge of 952008b

@wildfly-ci
Copy link

Linux Build 4707 is now running using a merge of 952008b

@wildfly-ci
Copy link

Linux Build 4705 outcome was FAILURE using a merge of 952008b
Summary: Tests failed: 1 (1 new), passed: 2992, ignored: 252 Build time: 1:01:02

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.integration.ws.wsse.signencrypt.EJBSignEncryptMultipleClientsTestCase.encryptedAndSignedRequestFromJohn: javax.xml.ws.WebServiceException: Could not send Message.
    at java.net.SocketInputStream.socketRead0(Native Method)
    at java.net.SocketInputStream.read(SocketInputStream.java:152)

@wildfly-ci
Copy link

Linux Build 4706 outcome was SUCCESS using a merge of 952008b
Summary: Tests passed: 2993, ignored: 252 Build time: 1:01:24

@wildfly-ci
Copy link

Linux Build 4707 outcome was SUCCESS using a merge of 952008b
Summary: Tests passed: 2993, ignored: 252 Build time: 1:05:07

bstansberry added a commit that referenced this pull request Sep 3, 2014
[WFLY-2879] - Remove duplicated code from test cases where custom module...
@bstansberry bstansberry merged commit 73f7656 into wildfly:master Sep 3, 2014
@kabir kabir deleted the pedro-pr-6577 branch September 2, 2015 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold PR should not be merged for some reason.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants