-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFLY-2879] - Remove duplicated code from test cases where custom module... #6658
Conversation
Linux Build 4688 is now running using a merge of 0109206 |
Linux Build 4688 outcome was FAILURE using a merge of 0109206 Build problems:Failed tests detected Failed tests
|
Linux Build 4689 is now running using a merge of 4a395b0 |
Linux Build 4689 outcome was FAILURE using a merge of 4a395b0 Build problems:Failed tests detected Failed tests
|
@@ -46,15 +43,18 @@ | |||
|
|||
@Inject | |||
private InjectedBean injectedBean; | |||
private static TestModule testModule; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to also package this class up in the test archive
…nce TestModule is available in the next wildfly-core release
Linux Build 4705 is now running using a merge of 952008b |
Linux Build 4706 is now running using a merge of 952008b |
Linux Build 4707 is now running using a merge of 952008b |
Linux Build 4705 outcome was FAILURE using a merge of 952008b Build problems:Failed tests detected Failed tests
|
Linux Build 4706 outcome was SUCCESS using a merge of 952008b |
Linux Build 4707 outcome was SUCCESS using a merge of 952008b |
[WFLY-2879] - Remove duplicated code from test cases where custom module...
...s are needed.
This was originally #6577 but it appears that got closed rather than merged. I noticed this when doing https://github.com/jbossas/jboss-eap/pull/1629 which then showed that this work was not part of upstream.
The TempTestModule class needs to be removed once wildfly/wildfly-core#151 has been released, and updated to use TestModule from wildfly-core. https://issues.jboss.org/browse/WFLY-3807 is there to make sure this does not get forgotten.