WFLY-3810 Graceful shutdown support for mod_cluster #6914

stuartwdouglas · 2014-11-05T21:52:12Z

No description provided.

stuartwdouglas · 2014-11-05T21:54:20Z

@jfclere @rhusar does this look ok to you guys?

wildfly-ci · 2014-11-05T21:55:15Z

Windows Build 521 is now running using a merge of 8249112

wildfly-ci · 2014-11-05T21:55:15Z

Linux Build 5418 is now running using a merge of 8249112

wildfly-ci · 2014-11-05T21:55:16Z

Linux with security manager Build 407 is now running using a merge of 8249112

wildfly-ci · 2014-11-05T22:01:41Z

Linux with security manager Build 407 outcome was SUCCESS using a merge of 8249112
Summary: Tests passed: 796, ignored: 244 Build time: 0:06:27

wildfly-ci · 2014-11-06T00:55:25Z

Linux Build 5418 outcome was FAILURE using a merge of 8249112
Summary: Execution timeout (new); tests passed: 2916, ignored: 239; org.wildfly:wildfly-testsuite-integration-domain Build time: 3:00:12

Build problems:

Execution timeout
Process exited with code 137

wildfly-ci · 2014-11-06T00:55:34Z

Windows Build 521 outcome was FAILURE using a merge of 8249112
Summary: Execution timeout (new); tests passed: 2947, ignored: 239; org.wildfly:wildfly-testsuite-integration-domain Build time: 3:00:21

Build problems:

Execution timeout
Process exited with code 1

wildfly-ci · 2014-11-10T06:00:17Z

Linux Build 5438 is now running using a merge of 99dfd12

wildfly-ci · 2014-11-10T06:00:17Z

Linux with security manager Build 427 is now running using a merge of 99dfd12

wildfly-ci · 2014-11-10T06:00:17Z

Windows Build 541 is now running using a merge of 99dfd12

wildfly-ci · 2014-11-10T06:07:11Z

Linux with security manager Build 427 outcome was SUCCESS using a merge of 99dfd12
Summary: Tests passed: 796, ignored: 244 Build time: 0:06:55

wildfly-ci · 2014-11-10T06:52:15Z

Windows Build 541 outcome was SUCCESS using a merge of 99dfd12
Summary: Tests passed: 2996, ignored: 239, muted: 1 Build time: 0:51:59

wildfly-ci · 2014-11-10T08:47:53Z

Linux Build 5438 outcome was FAILURE using a merge of 99dfd12
Summary: Tests failed: 770 (770 new), passed: 772, ignored: 196, muted: 1 Build time: 2:47:36

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.smoke.rar.RarTestCase.helloWorld: javax.naming.NameNotFoundException: eis/HelloWorld -- service jboss.naming.context.java.eis.HelloWorld
    at org.jboss.as.naming.ServiceBasedNamingStore.lookup(ServiceBasedNamingStore.java:106)
    at org.jboss.as.naming.NamingContext.lookup(NamingContext.java:202)

org.jboss.as.test.smoke.rar.RarTestCase.helloWorld2: javax.naming.NameNotFoundException: eis/HelloWorld -- service jboss.naming.context.java.eis.HelloWorld
    at org.jboss.as.naming.ServiceBasedNamingStore.lookup(ServiceBasedNamingStore.java:106)
    at org.jboss.as.naming.NamingContext.lookup(NamingContext.java:202)

org.jboss.as.test.smoke.jaxrs.JaxrsTestCase.testJaxrs: java.io.IOException: java.util.concurrent.ExecutionException: java.io.IOException: HTTP Status 404 Response: <html><head><title>Error</title></head><body>Not Found</body></html>
    at java.util.concurrent.FutureTask.report(FutureTask.java:122)
    at java.util.concurrent.FutureTask.get(FutureTask.java:202)

org.jboss.as.test.smoke.ejb3.jndi.EarDeploymentEjbJndiBindingTestCase.testLocalBindingsOnSFSB: javax.naming.NameNotFoundException: ear-deployment-ejb3-binding/ejb3-jndi-binding-test/SampleSFSB!org.jboss.as.test.smoke.ejb3.jndi.Echo -- service jboss.naming.context.java.global.ear-deployment-ejb3-binding.ejb3-jndi-binding-test."SampleSFSB!org.jboss.as.test.smoke.ejb3.jndi.Echo"
    at org.jboss.as.naming.ServiceBasedNamingStore.lookup(ServiceBasedNamingStore.java:106)
    at org.jboss.as.naming.NamingContext.lookup(NamingContext.java:202)

org.jboss.as.test.smoke.ejb3.jndi.EarDeploymentEjbJndiBindingTestCase.testLocalBindingsOnSLSB: javax.naming.NameNotFoundException: ear-deployment-ejb3-binding/ejb3-jndi-binding-test/SampleSLSB!org.jboss.as.test.smoke.ejb3.jndi.Echo -- service jboss.naming.context.java.global.ear-deployment-ejb3-binding.ejb3-jndi-binding-test."SampleSLSB!org.jboss.as.test.smoke.ejb3.jndi.Echo"
    at org.jboss.as.naming.ServiceBasedNamingStore.lookup(ServiceBasedNamingStore.java:106)
    at org.jboss.as.naming.NamingContext.lookup(NamingContext.java:202)

org.jboss.as.test.smoke.ejb3.jndi.EarDeploymentEjbJndiBindingTestCase.testRemoteBindingsOnSFSB: javax.naming.NameNotFoundException: ear-deployment-ejb3-binding/ejb3-jndi-binding-test/SampleSFSB!org.jboss.as.test.smoke.ejb3.jndi.RemoteEcho -- service jboss.naming.context.java.global.ear-deployment-ejb3-binding.ejb3-jndi-binding-test."SampleSFSB!org.jboss.as.test.smoke.ejb3.jndi.RemoteEcho"
    at org.jboss.as.naming.ServiceBasedNamingStore.lookup(ServiceBasedNamingStore.java:106)
    at org.jboss.as.naming.NamingContext.lookup(NamingContext.java:202)

org.jboss.as.test.smoke.ejb3.jndi.EarDeploymentEjbJndiBindingTestCase.testRemoteBindingsOnSLSB: javax.naming.NameNotFoundException: ear-deployment-ejb3-binding/ejb3-jndi-binding-test/SampleSLSB!org.jboss.as.test.smoke.ejb3.jndi.RemoteEcho -- service jboss.naming.context.java.global.ear-deployment-ejb3-binding.ejb3-jndi-binding-test."SampleSLSB!org.jboss.as.test.smoke.ejb3.jndi.RemoteEcho"
    at org.jboss.as.naming.ServiceBasedNamingStore.lookup(ServiceBasedNamingStore.java:106)
    at org.jboss.as.naming.NamingContext.lookup(NamingContext.java:202)

org.jboss.as.test.smoke.ejb3.dd.DDBasedEJBTestCase: org.jboss.as.test.smoke.ejb3.jndi.StandaloneModuleEjbJndiBindingTestCase.testLocalBindingsOnSFSB: javax.naming.NameNotFoundException: ejb3-jndi-binding-test/SampleSFSB!org.jboss.as.test.smoke.ejb3.jndi.Echo -- service jboss.naming.context.java.global.ejb3-jndi-binding-test."SampleSFSB!org.jboss.as.test.smoke.ejb3.jndi.Echo"
    at org.jboss.as.naming.ServiceBasedNamingStore.lookup(ServiceBasedNamingStore.java:106)
    at org.jboss.as.naming.NamingContext.lookup(NamingContext.java:202)

org.jboss.as.test.smoke.ejb3.dd.DDBasedEJBTestCase: org.jboss.as.test.smoke.ejb3.jndi.StandaloneModuleEjbJndiBindingTestCase.testLocalBindingsOnSLSB: javax.naming.NameNotFoundException: ejb3-jndi-binding-test/SampleSLSB!org.jboss.as.test.smoke.ejb3.jndi.Echo -- service jboss.naming.context.java.global.ejb3-jndi-binding-test."SampleSLSB!org.jboss.as.test.smoke.ejb3.jndi.Echo"
    at org.jboss.as.naming.ServiceBasedNamingStore.lookup(ServiceBasedNamingStore.java:106)
    at org.jboss.as.naming.NamingContext.lookup(NamingContext.java:202)

org.jboss.as.test.smoke.ejb3.dd.DDBasedEJBTestCase: org.jboss.as.test.smoke.ejb3.jndi.StandaloneModuleEjbJndiBindingTestCase.testRemoteBindingsOnSFSB: javax.naming.NameNotFoundException: ejb3-jndi-binding-test/SampleSFSB!org.jboss.as.test.smoke.ejb3.jndi.RemoteEcho -- service jboss.naming.context.java.global.ejb3-jndi-binding-test."SampleSFSB!org.jboss.as.test.smoke.ejb3.jndi.RemoteEcho"
    at org.jboss.as.naming.ServiceBasedNamingStore.lookup(ServiceBasedNamingStore.java:106)
    at org.jboss.as.naming.NamingContext.lookup(NamingContext.java:202)

org.jboss.as.test.smoke.ejb3.dd.DDBasedEJBTestCase: org.jboss.as.test.smoke.ejb3.jndi.StandaloneModuleEjbJndiBindingTestCase.testRemoteBindingsOnSLSB: javax.naming.NameNotFoundException: ejb3-jndi-binding-test/SampleSLSB!org.jboss.as.test.smoke.ejb3.jndi.RemoteEcho -- service jboss.naming.context.java.global.ejb3-jndi-binding-test."SampleSLSB!org.jboss.as.test.smoke.ejb3.jndi.RemoteEcho"
    at org.jboss.as.naming.ServiceBasedNamingStore.lookup(ServiceBasedNamingStore.java:106)
    at org.jboss.as.naming.NamingContext.lookup(NamingContext.java:202)


##### there are 760 more failed tests, see build details

stuartwdouglas · 2014-11-10T21:56:25Z

Retest this please

wildfly-ci · 2014-11-10T22:00:21Z

Linux with security manager Build 439 is now running using a merge of 99dfd12

wildfly-ci · 2014-11-10T22:00:21Z

Linux Build 5450 is now running using a merge of 99dfd12

wildfly-ci · 2014-11-10T22:00:22Z

Windows Build 553 is now running using a merge of 99dfd12

wildfly-ci · 2014-11-10T22:07:28Z

Linux with security manager Build 439 outcome was SUCCESS using a merge of 99dfd12
Summary: Tests passed: 796, ignored: 244 Build time: 0:07:08

wildfly-ci · 2014-11-10T22:52:03Z

Windows Build 553 outcome was SUCCESS using a merge of 99dfd12
Summary: Tests passed: 2996, ignored: 239, muted: 1 Build time: 0:51:44

wildfly-ci · 2014-11-10T22:54:28Z

Linux Build 5450 outcome was FAILURE using a merge of 99dfd12
Summary: Tests failed: 1 (1 new), passed: 2995, ignored: 239, muted: 1 Build time: 0:54:09

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.integration.ejb.stateful.passivation.PassivationTestCase.testPassivationMaxSize: javax.ejb.EJBException: java.lang.IllegalStateException: WFLYCLEJBINF0008: Stateful session bean {[105, 39, 10, 99, 46, 12, 69, 95, -79, 94, -103, 114, 75, -23, 10, -59]} refers to an invalid bean group 55b5d11b-d76a-46e1-aa7f-1551d6c28a12
    at org.wildfly.clustering.ejb.infinispan.bean.InfinispanBeanFactory.createBean(InfinispanBeanFactory.java:75)
    at org.wildfly.clustering.ejb.infinispan.InfinispanBeanManager.findBean(InfinispanBeanManager.java:266)

rhusar · 2014-11-14T03:43:40Z

Unfortunately I haven't finished reviewing this, but last I was wondering whether we don't have to do a modcluster shutdown instead. But if the listener/connector is still handling CPING/CPONG for AJP and OPTIONS for HTTP when suspended then it shouldn't be a problem.

jfclere · 2014-11-14T07:01:21Z

Not answering to CPING or OPTIONS will just mark the node in error (in some cases after a timeout)

rhusar · 2014-11-14T07:17:19Z

Looking again at the code and design proposal, the server should answer to ping mechanisms even when paused. Therefore, I think this PR looks good and does what we need. 👍

bstansberry · 2014-11-18T21:56:07Z

Based on the above comments, I'm marking this ready for merge.

WFLY-3810 Graceful shutdown support for mod_cluster

WFLY-3810 Graceful shutdown support for mod_cluster

99dfd12

stuartwdouglas force-pushed the WFLY-3810 branch from 8249112 to 99dfd12 Compare November 10, 2014 05:57

bstansberry added the ready-for-merge Only for use by those with merge permissions! label Nov 18, 2014

bstansberry added a commit that referenced this pull request Nov 19, 2014

Merge pull request #6914 from stuartwdouglas/WFLY-3810

d7d833f

WFLY-3810 Graceful shutdown support for mod_cluster

bstansberry merged commit d7d833f into wildfly:master Nov 19, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WFLY-3810 Graceful shutdown support for mod_cluster #6914

WFLY-3810 Graceful shutdown support for mod_cluster #6914

stuartwdouglas commented Nov 5, 2014

stuartwdouglas commented Nov 5, 2014

wildfly-ci commented Nov 5, 2014

wildfly-ci commented Nov 5, 2014

wildfly-ci commented Nov 5, 2014

wildfly-ci commented Nov 5, 2014

wildfly-ci commented Nov 6, 2014

wildfly-ci commented Nov 6, 2014

wildfly-ci commented Nov 10, 2014

wildfly-ci commented Nov 10, 2014

wildfly-ci commented Nov 10, 2014

wildfly-ci commented Nov 10, 2014

wildfly-ci commented Nov 10, 2014

wildfly-ci commented Nov 10, 2014

stuartwdouglas commented Nov 10, 2014

wildfly-ci commented Nov 10, 2014

wildfly-ci commented Nov 10, 2014

wildfly-ci commented Nov 10, 2014

wildfly-ci commented Nov 10, 2014

wildfly-ci commented Nov 10, 2014

wildfly-ci commented Nov 10, 2014

rhusar commented Nov 14, 2014

jfclere commented Nov 14, 2014

rhusar commented Nov 14, 2014

bstansberry commented Nov 18, 2014

WFLY-3810 Graceful shutdown support for mod_cluster #6914

WFLY-3810 Graceful shutdown support for mod_cluster #6914

Conversation

stuartwdouglas commented Nov 5, 2014

stuartwdouglas commented Nov 5, 2014

wildfly-ci commented Nov 5, 2014

wildfly-ci commented Nov 5, 2014

wildfly-ci commented Nov 5, 2014

wildfly-ci commented Nov 5, 2014

wildfly-ci commented Nov 6, 2014

Build problems:

wildfly-ci commented Nov 6, 2014

Build problems:

wildfly-ci commented Nov 10, 2014

wildfly-ci commented Nov 10, 2014

wildfly-ci commented Nov 10, 2014

wildfly-ci commented Nov 10, 2014

wildfly-ci commented Nov 10, 2014

wildfly-ci commented Nov 10, 2014

Build problems:

Failed tests

stuartwdouglas commented Nov 10, 2014

wildfly-ci commented Nov 10, 2014

wildfly-ci commented Nov 10, 2014

wildfly-ci commented Nov 10, 2014

wildfly-ci commented Nov 10, 2014

wildfly-ci commented Nov 10, 2014

wildfly-ci commented Nov 10, 2014

Build problems:

Failed tests

rhusar commented Nov 14, 2014

jfclere commented Nov 14, 2014

rhusar commented Nov 14, 2014

bstansberry commented Nov 18, 2014