New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WFLY-4928 Feature pack modules are built in the wrong order #7759
Conversation
Linux with security manager Build 1911 is now running using a merge of d1c28dd |
Linux Build 7035 is now running using a merge of d1c28dd |
@@ -308,6 +307,7 @@ | |||
<module>web-common</module> | |||
<module>servlet-dist</module> | |||
<module>servlet-feature-pack</module> | |||
<module>feature-pack</module> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that shouldn't matter at all. as long as there are proper dependencies in place, maven will figure out the proper order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I double-checked, and it seems you're right: my local build is working fine now even without this patch. I'm wondering though if something is now locally cached.
You have a better theory to explain the build error I had ?
[ERROR] Failed to execute goal on project wildfly-feature-pack: Could not resolve dependencies for project org.wildfly:wildfly-feature-pack:pom:10.0.0.Alpha6-SNAPSHOT: Failure to find org.wildfly:wildfly-servlet-feature-pack:zip:10.0.0.Alpha6-SNAPSHOT in http://repository.jboss.org/nexus/content/groups/public/ was cached in the local repository, resolution will not be reattempted until the update interval of jboss-public-repository-group has elapsed or updates are forced -> [Help 1]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do you build it? just mvn clean install or any special params?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the README
suggests:
./build.sh test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to do ./build.sh install to install the servlet feature pack into the local repository.
Windows Build 2090 is now running using a merge of d1c28dd |
Linux with security manager Build 1911 outcome was SUCCESS using a merge of d1c28dd |
Windows Build 2090 outcome was SUCCESS using a merge of d1c28dd |
Linux Build 7035 outcome was FAILURE using a merge of d1c28dd Build problems:Failed tests detected Failed tests
|
sorry for the delay, I've been away. Thanks, that makes sense I probably built it the wrong way, and can't reproduce it anymore. |
https://issues.jboss.org/browse/WFLY-4928