Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WFLY-4928 Feature pack modules are built in the wrong order #7759

Closed
wants to merge 1 commit into from
Closed

WFLY-4928 Feature pack modules are built in the wrong order #7759

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,6 @@
<module>ee</module>
<module>ejb3</module>
<module>embedded</module>
<module>feature-pack</module>
<module>iiop-openjdk</module>
<module>jaxrs</module>
<module>jdr</module>
Expand Down Expand Up @@ -308,6 +307,7 @@
<module>web-common</module>
<module>servlet-dist</module>
<module>servlet-feature-pack</module>
<module>feature-pack</module>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that shouldn't matter at all. as long as there are proper dependencies in place, maven will figure out the proper order.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double-checked, and it seems you're right: my local build is working fine now even without this patch. I'm wondering though if something is now locally cached.

You have a better theory to explain the build error I had ?

[ERROR] Failed to execute goal on project wildfly-feature-pack: Could not resolve dependencies for project org.wildfly:wildfly-feature-pack:pom:10.0.0.Alpha6-SNAPSHOT: Failure to find org.wildfly:wildfly-servlet-feature-pack:zip:10.0.0.Alpha6-SNAPSHOT in http://repository.jboss.org/nexus/content/groups/public/ was cached in the local repository, resolution will not be reattempted until the update interval of jboss-public-repository-group has elapsed or updates are forced -> [Help 1]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do you build it? just mvn clean install or any special params?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the README suggests:

./build.sh test

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to do ./build.sh install to install the servlet feature pack into the local repository.

<module>webservices</module>
<module>weld</module>
<module>xts</module>
Expand Down