[WFLY-4811] Add new batch-jberet subsystems #7806

jamezp · 2015-07-21T17:19:08Z

This PR adds a new batch-jberet subsystem.

First Commit

This commit reverts a change to the original batch subsystem that will only be allowed in the new subsystem.

Second Commit

This commit brings JBeret to a level required for the new subsystem.

Third Commit

This commit just changes a few things to prepare for the new subsystem. It could be squashed with the next commit, but for the review process it may be easier having it separate.

Fourth Commit

This commit is the addition of the new subsystem. The new subsystem model looks like the following.

{
    "default-job-repository" => "in-memory",
    "default-thread-pool" => "batch",
    "in-memory-job-repository" => {"in-memory" => {}},
    "jdbc-job-repository" => {"jdbc" => {"data-source" => "test"}},
    "thread-factory" => undefined,
    "thread-pool" => {"batch" => {
        "keepalive-time" => {
            "time" => 30L,
            "unit" => "SECONDS"
        },
        "max-threads" => 10,
        "name" => "batch",
        "thread-factory" => undefined
    }}
}

This new model allows for the use of capabilities & requirements as well as hopefully cleans up the user experience. The default-job-repository and default-thread-pool attributes seem a bit awkward to me, but allow the deployments to work without a deployment descriptor.

The JNDI name is no longer used for a jdbc-job-repository. The data source capability is used and the data source is no longer looked up via a JNDI lookup.

Multiple thread pools and job repositories are allowed to be defined. The jboss-all.xml deployment descriptor can be used to define specific job repositories or thread pools to the deployment.

Once this is acceptable I will submit a PR for the capabilities documentation.

Fifth Commit

This is just the tests and can be squashed with the third commit. I only left this separate as it may be easier to review the commits separated.

wildfly-ci · 2015-07-21T17:23:43Z

Windows Build 2176 is now running using a merge of 7eca336

wildfly-ci · 2015-07-21T17:23:44Z

Linux Build 7124 is now running using a merge of 7eca336

wildfly-ci · 2015-07-21T17:23:44Z

Linux with security manager Build 1997 is now running using a merge of 7eca336

wildfly-ci · 2015-07-21T17:30:56Z

Linux with security manager Build 1997 outcome was SUCCESS using a merge of 7eca336
Summary: Tests passed: 889, ignored: 286 Build time: 0:07:13

wildfly-ci · 2015-07-21T18:08:38Z

Linux Build 7124 outcome was FAILURE using a merge of 7eca336
Summary: Tests failed: 9 (9 new), passed: 2934, ignored: 357 Build time: 0:44:55

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.integration.security.jacc.JACCAuthzPropagationTestCase.testBridge: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCAuthzPropagationTestCase.testTarget: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCForEarModulesTestCase.testWebPermissions: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCForEarModulesTestCase.testEJBPermissions: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCTranslateServletDDTestCase.testHTTPMethodCanonical: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCTranslateServletDDTestCase.testConnectionType: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCTranslateServletDDTestCase.testQualifiedPatterns: <no details avaliable>

org.jboss.as.test.integration.domain.mixed.eap630.MixedDomain630TestSuite: org.jboss.as.test.integration.domain.mixed.eap620.MixedDomain620TestSuite: <no details avaliable>

org.jboss.as.test.integration.domain.mixed.eap630.MixedDomain630TestSuite: <no details avaliable>

wildfly-ci · 2015-07-21T18:08:55Z

Windows Build 2176 outcome was FAILURE using a merge of 7eca336
Summary: Tests failed: 11 (9 new), passed: 2932, ignored: 357 Build time: 0:45:12

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.integration.security.jacc.JACCAuthzPropagationTestCase.testBridge: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCAuthzPropagationTestCase.testTarget: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCForEarModulesTestCase.testWebPermissions: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCForEarModulesTestCase.testEJBPermissions: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCTranslateServletDDTestCase.testHTTPMethodCanonical: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCTranslateServletDDTestCase.testConnectionType: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCTranslateServletDDTestCase.testQualifiedPatterns: <no details avaliable>

org.jboss.as.test.integration.domain.mixed.eap630.MixedDomain630TestSuite: org.jboss.as.test.integration.domain.mixed.eap620.MixedDomain620TestSuite: <no details avaliable>

org.jboss.as.test.integration.domain.mixed.eap630.MixedDomain630TestSuite: <no details avaliable>

org.jboss.as.test.clustering.xsite.XSiteSimpleTestCase.testPutRelayedToBackups: <no details avaliable>

org.jboss.as.test.manualmode.ejb.client.cluster.EJBClientClusterConfigurationTestCase.testServerToServerClusterFormation: <no details avaliable>


##### there are 1 more failed tests, see build details

jamezp · 2015-07-22T15:20:53Z

retest this please

wildfly-ci · 2015-07-22T15:23:45Z

Linux Build 7139 is now running using a merge of 7eca336

wildfly-ci · 2015-07-22T15:23:45Z

Windows Build 2192 is now running using a merge of 7eca336

wildfly-ci · 2015-07-22T15:23:46Z

Linux with security manager Build 2012 is now running using a merge of 7eca336

wildfly-ci · 2015-07-22T15:31:00Z

Linux with security manager Build 2012 outcome was SUCCESS using a merge of 7eca336
Summary: Tests passed: 889, ignored: 286 Build time: 0:07:15

wildfly-ci · 2015-07-22T16:08:51Z

Windows Build 2192 outcome was FAILURE using a merge of 7eca336
Summary: Tests failed: 9, passed: 2930, ignored: 359 Build time: 0:45:06

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.integration.security.jacc.JACCAuthzPropagationTestCase.testBridge: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCAuthzPropagationTestCase.testTarget: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCForEarModulesTestCase.testWebPermissions: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCForEarModulesTestCase.testEJBPermissions: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCTranslateServletDDTestCase.testHTTPMethodCanonical: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCTranslateServletDDTestCase.testConnectionType: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCTranslateServletDDTestCase.testQualifiedPatterns: <no details avaliable>

org.jboss.as.test.integration.domain.mixed.eap630.MixedDomain630TestSuite: org.jboss.as.test.integration.domain.mixed.eap620.MixedDomain620TestSuite: <no details avaliable>

org.jboss.as.test.integration.domain.mixed.eap630.MixedDomain630TestSuite: <no details avaliable>

wildfly-ci · 2015-07-22T16:10:41Z

Linux Build 7139 outcome was FAILURE using a merge of 7eca336
Summary: Tests failed: 9, passed: 2930, ignored: 359 Build time: 0:46:56

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.integration.security.jacc.JACCAuthzPropagationTestCase.testBridge: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCAuthzPropagationTestCase.testTarget: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCForEarModulesTestCase.testWebPermissions: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCForEarModulesTestCase.testEJBPermissions: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCTranslateServletDDTestCase.testHTTPMethodCanonical: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCTranslateServletDDTestCase.testConnectionType: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCTranslateServletDDTestCase.testQualifiedPatterns: <no details avaliable>

org.jboss.as.test.integration.domain.mixed.eap630.MixedDomain630TestSuite: org.jboss.as.test.integration.domain.mixed.eap620.MixedDomain620TestSuite: <no details avaliable>

org.jboss.as.test.integration.domain.mixed.eap630.MixedDomain630TestSuite: <no details avaliable>

wildfly-ci · 2015-07-22T20:34:13Z

Linux Build 7144 is now running using a merge of e6c5e16

wildfly-ci · 2015-07-22T20:34:14Z

Windows Build 2197 is now running using a merge of e6c5e16

wildfly-ci · 2015-07-22T20:34:14Z

Linux with security manager Build 2017 is now running using a merge of e6c5e16

wildfly-ci · 2015-07-22T20:41:40Z

Linux with security manager Build 2017 outcome was SUCCESS using a merge of e6c5e16
Summary: Tests passed: 889, ignored: 286 Build time: 0:07:27

wildfly-ci · 2015-07-22T21:19:51Z

Linux Build 7144 outcome was FAILURE using a merge of e6c5e16
Summary: Tests failed: 9, passed: 2933, ignored: 357 Build time: 0:45:38

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.integration.security.jacc.JACCAuthzPropagationTestCase.testBridge: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCAuthzPropagationTestCase.testTarget: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCForEarModulesTestCase.testWebPermissions: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCForEarModulesTestCase.testEJBPermissions: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCTranslateServletDDTestCase.testHTTPMethodCanonical: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCTranslateServletDDTestCase.testConnectionType: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCTranslateServletDDTestCase.testQualifiedPatterns: <no details avaliable>

org.jboss.as.test.integration.domain.mixed.eap630.MixedDomain630TestSuite: org.jboss.as.test.integration.domain.mixed.eap620.MixedDomain620TestSuite: <no details avaliable>

org.jboss.as.test.integration.domain.mixed.eap630.MixedDomain630TestSuite: <no details avaliable>

wildfly-ci · 2015-07-22T21:20:22Z

Windows Build 2197 outcome was FAILURE using a merge of e6c5e16
Summary: Tests failed: 11, passed: 2931, ignored: 357 Build time: 0:46:10

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.integration.security.jacc.JACCAuthzPropagationTestCase.testBridge: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCAuthzPropagationTestCase.testTarget: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCForEarModulesTestCase.testWebPermissions: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCForEarModulesTestCase.testEJBPermissions: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCTranslateServletDDTestCase.testHTTPMethodCanonical: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCTranslateServletDDTestCase.testConnectionType: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCTranslateServletDDTestCase.testQualifiedPatterns: <no details avaliable>

org.jboss.as.test.clustering.xsite.XSiteSimpleTestCase.testPutRelayedToBackups: <no details avaliable>

org.jboss.as.test.manualmode.ejb.client.cluster.EJBClientClusterConfigurationTestCase.testServerToServerClusterFormation: <no details avaliable>

org.jboss.as.test.integration.domain.mixed.eap630.MixedDomain630TestSuite: org.jboss.as.test.integration.domain.mixed.eap620.MixedDomain620TestSuite: <no details avaliable>

org.jboss.as.test.integration.domain.mixed.eap630.MixedDomain630TestSuite: <no details avaliable>


##### there are 1 more failed tests, see build details

wildfly-ci · 2015-07-22T23:28:46Z

Linux Build 7146 is now running using a merge of 44b096d

wildfly-ci · 2015-07-22T23:28:46Z

Windows Build 2199 is now running using a merge of 44b096d

wildfly-ci · 2015-07-22T23:28:47Z

Linux with security manager Build 2019 is now running using a merge of 44b096d

wildfly-ci · 2015-07-22T23:35:14Z

Linux with security manager Build 2019 outcome was SUCCESS using a merge of 44b096d
Summary: Tests passed: 889, ignored: 286 Build time: 0:06:28

wildfly-ci · 2015-07-23T00:15:07Z

Linux Build 7146 outcome was FAILURE using a merge of 44b096d
Summary: Tests failed: 7, passed: 2963, ignored: 357 Build time: 0:46:22

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.integration.security.jacc.JACCAuthzPropagationTestCase.testBridge: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCAuthzPropagationTestCase.testTarget: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCForEarModulesTestCase.testWebPermissions: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCForEarModulesTestCase.testEJBPermissions: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCTranslateServletDDTestCase.testHTTPMethodCanonical: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCTranslateServletDDTestCase.testConnectionType: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCTranslateServletDDTestCase.testQualifiedPatterns: <no details avaliable>

wildfly-ci · 2015-07-23T00:17:40Z

Windows Build 2199 outcome was FAILURE using a merge of 44b096d
Summary: Tests failed: 9, passed: 2961, ignored: 357 Build time: 0:48:54

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.integration.security.jacc.JACCAuthzPropagationTestCase.testBridge: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCAuthzPropagationTestCase.testTarget: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCForEarModulesTestCase.testWebPermissions: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCForEarModulesTestCase.testEJBPermissions: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCTranslateServletDDTestCase.testHTTPMethodCanonical: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCTranslateServletDDTestCase.testConnectionType: <no details avaliable>

org.jboss.as.test.integration.security.jacc.JACCTranslateServletDDTestCase.testQualifiedPatterns: <no details avaliable>

org.jboss.as.test.clustering.xsite.XSiteSimpleTestCase.testPutRelayedToBackups: <no details avaliable>

org.jboss.as.test.manualmode.ejb.client.cluster.EJBClientClusterConfigurationTestCase.testServerToServerClusterFormation: <no details avaliable>

…the jboss-all.xml deployment descriptor." This reverts commit bd8c818. This will only be present in the new batch-jberet subsystem.

wildfly-ci · 2015-07-23T16:09:22Z

Linux with security manager Build 2033 is now running using a merge of 949329c

wildfly-ci · 2015-07-23T16:09:22Z

Linux Build 7161 is now running using a merge of 949329c

wildfly-ci · 2015-07-23T16:09:23Z

Windows Build 2217 is now running using a merge of 949329c

wildfly-ci · 2015-07-23T16:18:39Z

Linux with security manager Build 2033 outcome was SUCCESS using a merge of 949329c
Summary: Tests passed: 891, ignored: 284 Build time: 0:09:18

wildfly-ci · 2015-07-23T16:56:24Z

Linux Build 7161 outcome was SUCCESS using a merge of 949329c
Summary: Tests passed: 2965, ignored: 356 Build time: 0:47:03

wildfly-ci · 2015-07-23T17:03:50Z

Windows Build 2217 outcome was SUCCESS using a merge of 949329c
Summary: Tests passed: 2963, ignored: 357, muted: 1 Build time: 0:54:28

[WFLY-4811] Add new batch-jberet subsystems

jamezp force-pushed the WFLY-4811-split branch from 7eca336 to e6c5e16 Compare July 22, 2015 20:32

jamezp force-pushed the WFLY-4811-split branch from e6c5e16 to 44b096d Compare July 22, 2015 23:25

jamezp added 3 commits July 23, 2015 09:05

Revert "[WFLY-2667] Allow batch job repositories to be overridden in …

247b13d

…the jboss-all.xml deployment descriptor." This reverts commit bd8c818. This will only be present in the new batch-jberet subsystem.

[WFLY-4933] Upgrade JBeret from 1.1.0.Final to 1.2.0.Alpha2

bea674b

Prepare for new batch-jberet subsystem.

05e591a

jamezp added 2 commits July 23, 2015 09:05

[WFLY-4811] Add new batch-jberet subsystem.

b68d5f8

[WFLY-4811] Add tests for new batch-jberet subsystem.

949329c

jamezp force-pushed the WFLY-4811-split branch from 44b096d to 949329c Compare July 23, 2015 16:06

tomjenkinson mentioned this pull request Jul 24, 2015

WFLY-4294 remove RUNTIME stage for :enable :disable operation for (xa… #7811

Merged

n1hility added a commit that referenced this pull request Jul 29, 2015

Merge pull request #7806 from jamezp/WFLY-4811-split

a64ddc7

[WFLY-4811] Add new batch-jberet subsystems

n1hility merged commit a64ddc7 into wildfly:master Jul 29, 2015

jamezp deleted the WFLY-4811-split branch July 29, 2015 22:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WFLY-4811] Add new batch-jberet subsystems #7806

[WFLY-4811] Add new batch-jberet subsystems #7806

jamezp commented Jul 21, 2015

wildfly-ci commented Jul 21, 2015

wildfly-ci commented Jul 21, 2015

wildfly-ci commented Jul 21, 2015

wildfly-ci commented Jul 21, 2015

wildfly-ci commented Jul 21, 2015

wildfly-ci commented Jul 21, 2015

jamezp commented Jul 22, 2015

wildfly-ci commented Jul 22, 2015

wildfly-ci commented Jul 22, 2015

wildfly-ci commented Jul 22, 2015

wildfly-ci commented Jul 22, 2015

wildfly-ci commented Jul 22, 2015

wildfly-ci commented Jul 22, 2015

wildfly-ci commented Jul 22, 2015

wildfly-ci commented Jul 22, 2015

wildfly-ci commented Jul 22, 2015

wildfly-ci commented Jul 22, 2015

wildfly-ci commented Jul 22, 2015

wildfly-ci commented Jul 22, 2015

wildfly-ci commented Jul 22, 2015

wildfly-ci commented Jul 22, 2015

wildfly-ci commented Jul 22, 2015

wildfly-ci commented Jul 22, 2015

wildfly-ci commented Jul 23, 2015

wildfly-ci commented Jul 23, 2015

wildfly-ci commented Jul 23, 2015

wildfly-ci commented Jul 23, 2015

wildfly-ci commented Jul 23, 2015

wildfly-ci commented Jul 23, 2015

wildfly-ci commented Jul 23, 2015

wildfly-ci commented Jul 23, 2015

[WFLY-4811] Add new batch-jberet subsystems #7806

[WFLY-4811] Add new batch-jberet subsystems #7806

Conversation

jamezp commented Jul 21, 2015

First Commit

Second Commit

Third Commit

Fourth Commit

Fifth Commit

wildfly-ci commented Jul 21, 2015

wildfly-ci commented Jul 21, 2015

wildfly-ci commented Jul 21, 2015

wildfly-ci commented Jul 21, 2015

wildfly-ci commented Jul 21, 2015

Build problems:

Failed tests

wildfly-ci commented Jul 21, 2015

Build problems:

Failed tests

jamezp commented Jul 22, 2015

wildfly-ci commented Jul 22, 2015

wildfly-ci commented Jul 22, 2015

wildfly-ci commented Jul 22, 2015

wildfly-ci commented Jul 22, 2015

wildfly-ci commented Jul 22, 2015

Build problems:

Failed tests

wildfly-ci commented Jul 22, 2015

Build problems:

Failed tests

wildfly-ci commented Jul 22, 2015

wildfly-ci commented Jul 22, 2015

wildfly-ci commented Jul 22, 2015

wildfly-ci commented Jul 22, 2015

wildfly-ci commented Jul 22, 2015

Build problems:

Failed tests

wildfly-ci commented Jul 22, 2015

Build problems:

Failed tests

wildfly-ci commented Jul 22, 2015

wildfly-ci commented Jul 22, 2015

wildfly-ci commented Jul 22, 2015

wildfly-ci commented Jul 22, 2015

wildfly-ci commented Jul 23, 2015

Build problems:

Failed tests

wildfly-ci commented Jul 23, 2015

Build problems:

Failed tests

wildfly-ci commented Jul 23, 2015

wildfly-ci commented Jul 23, 2015

wildfly-ci commented Jul 23, 2015

wildfly-ci commented Jul 23, 2015

wildfly-ci commented Jul 23, 2015

wildfly-ci commented Jul 23, 2015