New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WFLY-4255 Allow Arquillian to specify a timeout value for the WildFly clean shutdown mechanism when shutting down a server #8149
WFLY-4255 Allow Arquillian to specify a timeout value for the WildFly clean shutdown mechanism when shutting down a server #8149
Conversation
retest this please |
940d7fe
to
94c7d33
Compare
Just to update on this: this is still undergoing investigation but it is mostly likely uncovering a real problem. The test needs improvements (as discussed on the clustering call last week) as to fail, rather than hang. Primarily @rachmatowicz is investigating now. |
94c7d33
to
3695f28
Compare
3695f28
to
37d9ab8
Compare
retest this please |
37d9ab8
to
c92a8aa
Compare
c92a8aa
to
dfc8d84
Compare
dfc8d84
to
e4ffd4a
Compare
e4ffd4a
to
6e876d9
Compare
6e876d9
to
bc95c00
Compare
@bstansberry Thanks for the info, updated to 1.1.0.Final. |
Yes should be good to go for 11. |
bc95c00
to
b4c628f
Compare
b4c628f
to
4ad09ab
Compare
4ad09ab
to
f7dc5c4
Compare
@rhusar looking at failures, they do look related to this change. |
Just placed a hold on this @rhusar since you said you were going to fix it. Once you're done I'll remove the hold label. |
1976210
to
38225f8
Compare
I have split the test case into 2 by failover type and asked @rachmatowicz for review. |
Perfect, thanks @rhusar. I'll wait for a comment from @rachmatowicz before I change any labels. |
38225f8
to
58eb989
Compare
@jamezp Had a detailed look at this PR and all is well. This is a significant milestone for us in terms of being able to test with clean shutdown, so any help getting this merged quickly would be appreciated. |
58eb989
to
f14e465
Compare
BTW I have started about 40 CI runs for this PR and all is good. |
f14e465
to
6bbc2e2
Compare
Anything holding this back? Marked read-for-merge 3 weeks ago and master is already branched. |
When I first labeled it master wasn't at 11.x yet. Let's retest this please one more time. |
6bbc2e2
to
b30367a
Compare
Started a bunch of runs; around 15. |
Yeah I noticed that after I typed the message :) |
Windows Build 5233 outcome was FAILURE using a merge of b30367a Failed tests
|
Linux Build 10197 outcome was FAILURE using a merge of b30367a |
@@ -218,7 +218,7 @@ | |||
<version.org.wildfly.build-tools>1.1.3.Final</version.org.wildfly.build-tools> | |||
<version.org.wildfly.checkstyle-config>1.0.5.Final</version.org.wildfly.checkstyle-config> | |||
<version.org.wildfly.core>3.0.0.Alpha5</version.org.wildfly.core> | |||
<version.org.wildfly.arquillian>1.0.2.Final</version.org.wildfly.arquillian> | |||
<version.org.wildfly.arquillian>1.1.0.Final</version.org.wildfly.arquillian> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should really move to 2.0.0.Final at this point.
Could you update PR to that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, lets try that, if all passes then we are good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, all good. Started 10 more runs just in case.
… clean shutdown mechanism when shutting down a server WFLY-3532 Reenable RemoteFailoverTestCase stabilized by graceful shutdown arquillian support
b30367a
to
2c5bc76
Compare
Linux Build 10223 outcome was FAILURE using a merge of 2c5bc76 Failed tests
|
Jiras
https://issues.jboss.org/browse/WFLY-6615
https://issues.jboss.org/browse/WFLY-4255
https://issues.jboss.org/browse/WFLY-3532
@jamezp is afraid this might jeopardy testsuite stability and prefers to have this in 11.x
@rachmatowicz believes we cannot support RemoteFailoverTestCase without support for graceful shutdown