[WFLY-6448] Allow exclusion of kernel xsd schemas during testing of c… #8813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ore snapshots
Prevents StandardConfigsXMLValidationUnitTestCase rejecting full's valid standard config files when testing a core snapshot that includes a new kernel xsd version.
To use, assuming a core version named "3.0.0.Alpha1-SNAPSHOT" is being tested in full, and it includes a new xsd named wildfly-config_5_0.xsd:
Include -Dversion.org.wildfly.core=3.0.0.Alpha1-SNAPSHOT in the params passed to mvn when running full's testsuite. (This is the normal way you test a core snapshot; nothing related to this PR here).
Also, include -Djboss.test.xml.validation.future.schemas=3.0.0.Alpha1-SNAPSHOT/wildfly-config_5_0.xsd in the params passed to mvn.
So, format of the new sys prop's value is core_version/xsd_file.
If for some reason you need more than one file, the system property value can be a comma delimited list with each element a / delimited pair.
Why use the pair in the new property and not just the file name? Doing this helps guard against people setting this up in a CI test setup, and then forgetting to clear it when the core version is released and the new xsd becomes the "current" one in full. A schema file is only considered to be a "future" one if the core_version part matches the core version being tested.