Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packet tweaks #13

Merged
merged 3 commits into from
Feb 1, 2017
Merged

Packet tweaks #13

merged 3 commits into from
Feb 1, 2017

Conversation

willmcgugan
Copy link
Contributor

What this PR solves

  • Null packets produced an error in the log
  • Log packets have reduced importance, so end-users won't see them by default

How it is done

  • packet handler

What to look out for

  • screw ups

Review

  • Ready for review

@wildfoundry/web-developers

stuartkmarsh
stuartkmarsh approved these changes Feb 1, 2017
View reviewed changes
Copy link
Contributor

@stuartkmarsh stuartkmarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@willmcgugan willmcgugan merged commit 44af640 into master Feb 1, 2017
@willmcgugan willmcgugan deleted the packet-tweaks branch February 1, 2017 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartkmarsh stuartkmarsh stuartkmarsh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willmcgugan @stuartkmarsh