Take 2 of "treat paths as relative to Jekyll source directory"
#36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wildlyinaccurate
changed the title
souce directory"source directory"
Paths are still passed around as relative. Code which needs to read files (images, templates) and code which needs to manipulate paths (Jekyll::ResponsiveImage::Utils#image_hash) has to be aware of the site source path. This got a bit messy in the end, but I couldn't find a better way without doing a big refactor of the entire plugin.
wildlyinaccurate
force-pushed
the
source-directory-take-2
branch
from
e167d8a
to
854aa4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.