Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Design Feedback & Requests #8

Closed
erdumlauf12 opened this issue Nov 15, 2017 · 5 comments
Closed

Design Feedback & Requests #8

erdumlauf12 opened this issue Nov 15, 2017 · 5 comments

Comments

@erdumlauf12
Copy link

erdumlauf12 commented Nov 15, 2017

Looks good, see this image for some thoughts on everything

https://i.imgur.com/sbGpUuW.png

@wilfredwee
Copy link
Owner

Thanks for the feedback! I'll see what I can do. Pull requests always welcomed!

@Blu3wolf
Copy link

Similar thoughts. In particular I cant see the borders of the other tabs.

Ive had a quick look to see if I can fix it myself, but Im not sure about the classes here - I can use CSS a little, but I dont know which classes affect which parts of the tabs. Hence my comment rather than a PR.

@citbr
Copy link

citbr commented Nov 19, 2017

This is just what I was coming in to ask about. Other than the active tab, and any tabs I hover over, none have a clearly defined outline - they just sort of fade into the theme background, and all you see is the text and favicon. I'm using a light blue theme, so either a gray line defining the tab edges or a way to specify a specific color and opacity (basically a color tint) for each type of tab would work for me.

@Blu3wolf
Copy link

I dont even get hover effects, actually!

@doej1367
Copy link

doej1367 commented Feb 15, 2018

Similar thoughts as well.
In the old version of Firefox, the other tabs had no outline as well, but there were

  • vertical lines between those tabs
    (i think they realy need outlines. Any outlines. When i first saw it, I thought this would be a bug...)

and you could see the

and at last the view more tabs is already correct, if compared to this old version of Firefox.
In my opinion: these

  • don't need to have a curve

'- exept @wozmatic realy badly wants them to ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants