Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Research lifetimes and add to implementation #12

Open
wilhelmagren opened this issue Oct 9, 2022 · 0 comments
Open

Research lifetimes and add to implementation #12

wilhelmagren opened this issue Oct 9, 2022 · 0 comments
Assignees
@wilhelmagren
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed

Comments

@wilhelmagren
Copy link
Owner

I think currently the only way to make the borrowing of Tensors to the context (Function) is by specifying the lifetimes. But should all the Tensors live as long as the Functions? Are there any use cases were we want the Function and not the Tensor?; no, the Function is only a part of the context if a Tensor was created through an operation, i.e. it is not a leaf node in the DAG.
@wilhelmagren wilhelmagren added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed labels Oct 9, 2022
@wilhelmagren wilhelmagren self-assigned this Oct 9, 2022
wilhelmagren added a commit that referenced this issue Oct 9, 2022
@wilhelmagren
Lifetimes implemented and the code runs (#12)
db0a7ed
wilhelmagren added a commit that referenced this issue Oct 9, 2022
@wilhelmagren
New rewrite on structs, lifetimes are working and solved problems (#12)
ea1c37c
wilhelmagren added a commit that referenced this issue Oct 9, 2022
@wilhelmagren
Rewrite tests to follow new rewrite (#12)
204d0b7
wilhelmagren added a commit that referenced this issue Oct 9, 2022
@wilhelmagren
Update README with new rewrite structure (#12)
9e39baa
wilhelmagren added a commit that referenced this issue Oct 9, 2022
@wilhelmagren
Merge #16 from feature/readme to master
c0b8fc8 
Update README with new rewrite structure (#12)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilhelmagren wilhelmagren

Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wilhelmagren