Solve #24 – use font
gpar instead of fontface
to work with R 4.2.0
#25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #24 for me. I've checked carefully every
fontface
appearance in the package and fixed the critical places. Note that if you usefontface
ingpar()
, it is automatically "translated" tofont
(andfontface
is discarded) with appropriate integer code, so in those occasions, it could be left intact (I believe thisfont
-centered {grid} behavior will last many years to come).One special place is in
set_context_fontface()
– this is called only byprocess_tags()
, which utilizes character-basedfontface
argument, but it is used as positional argument in every occasion, so it works. The function retrieved face fromdrawing_context$gp$fontface
, which was in this PR changed to drawing_context$gp$font and subsequent usage of this retrieved face was edited to work with integerface
par.I tested the compatibility with {ggtext}, which also uses
fontface
at its last stage before handed over to {gridtext}. This is again accomplished by passingfontface
insidegpar()
, so it is "translated "correctly even in R 4.2.0.