QuickSelect #163
Closed
QuickSelect #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implement QuickSelect
implement test case
indentation
|
Thanks, I'm not super familiar with the Quick Select algorithm. I'll read up on it and get back to you. |
williamfiset
requested changes
May 12, 2020
| import org.junit.Test; | ||
|
|
||
| public class QuickSelectTest { | ||
|
|
There was a problem hiding this comment.
Can you add a test which fully tests the functionality of your quickselect implementation? I'm thinking of something like:
- Generate a range array of 100 random ints
- Make a sorted copy of the generated array
- Use the quick select algorithm to find the k'th smallest elements for all values of k between 1 and n.
- Make sure the quick select algorithm found the k'th smallest element by checking the k'th element in the sorted array
src/main/java/com/williamfiset/algorithms/search/QuickSelect.java
Outdated
Show resolved
Hide resolved
src/main/java/com/williamfiset/algorithms/search/QuickSelect.java
Outdated
Show resolved
Hide resolved
add header with description
kth smallest instead of largest
Update Test to match Quickselect
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolving issue #6