Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the HTTP status code of the failure. #11

Merged
merged 1 commit into from Aug 5, 2015

Conversation

carlossg
Copy link

@carlossg carlossg commented Aug 4, 2015

... so that for example 404 (not found) cannot be processed differently
from 503 (server temporarily unavailable)

... so that for example 404 (not found) cannot be processed differently
from 503 (server temporarily unavailable)
@seh
Copy link

seh commented Aug 4, 2015

Please see the outstanding issue #5 and PR #6 for a related proposal.

@carlossg
Copy link
Author

carlossg commented Aug 4, 2015

guess a dupe of #6

@seh
Copy link

seh commented Aug 4, 2015

Either approach solves the problem well enough, so I'd be happy with this one or #6. Both fix #5.

@WillAbides WillAbides merged commit a1de830 into willroden:master Aug 5, 2015
@seh
Copy link

seh commented Aug 5, 2015

One thing missed in a1de830 that 33e6463 took care of is removing the unnecessary "message" field in MarathonException. The base class Exception already stores the message supplied to its constructor, which MarathonException never calls now.

The question is whether to compose the message string lazily per demanded by a call to MarathonException#getMessage(), or whether to compose it at construction time and supply it to the Exception constructor. My 33e6463 proposed doing the latter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants