conn: remove the log.Errorf for non-NFS protocol errors #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code is calling log.Errorf for file system errors. File system errors can be frequent, as in a shell searching $PATH. These errors will be visible to the NFS client, and the NFS server are very confusing when running shells on NFS-mounted file systems, since the shell will handle the error. The shell is just one example; searches of LD_LIBRARY_PATH, /usr/include, etc: all produce copiuos error messages that are not needed. The error is returned to the client and can be handled there. Note that if there is a protocol-level error, such as failure to return a response packet, the error prints will still happen. In that case, it may be appropriate. Fixes willscott#117. Signed-off-by: Ronald G Minnich <rminnich@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code is calling log.Errorf for file system errors. File system errors can be frequent, as in a shell searching $PATH.
These errors will be visible to the NFS client, and the NFS server are very confusing when running shells on NFS-mounted file systems, since the shell will handle the error.
The shell is just one example; searches of LD_LIBRARY_PATH, /usr/include, etc: all produce copiuos error messages that are not needed. The error is returned to the client and can be handled there.
Note that if there is a protocol-level error, such as failure to return a response packet, the error prints will still happen. In that case, it may be appropriate.
Fixes #117.