Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conn: remove the log.Errorf for non-NFS protocol errors #133

Merged
merged 1 commit into from
Apr 25, 2024
Merged

conn: remove the log.Errorf for non-NFS protocol errors #133

merged 1 commit into from
Apr 25, 2024

Commits on Apr 24, 2024

  1. conn: remove the log.Errorf for non-NFS protocol errors 

    The current code is calling log.Errorf for file system errors.
File system errors can be frequent, as in a shell searching $PATH.

These errors will be visible to the NFS client, and the NFS server
are very confusing when running shells on NFS-mounted file
systems, since the shell will handle the error.

The shell is just one example; searches of LD_LIBRARY_PATH,
/usr/include, etc: all produce copiuos error messages that
are not needed. The error is returned to the client and
can be handled there.

Note that if there is a protocol-level error, such as failure
to return a response packet, the error prints will still happen.
In that case, it may be appropriate.

Fixes willscott#117.

Signed-off-by: Ronald G Minnich <rminnich@gmail.com>
    @rminnich
    rminnich committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    04b947a View commit details
    Browse the repository at this point in the history