Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instructions for running from source don't work. #20

Closed
dflock opened this issue Apr 18, 2017 · 1 comment
Closed

Instructions for running from source don't work. #20

dflock opened this issue Apr 18, 2017 · 1 comment

Comments

@dflock
Copy link
Contributor

dflock commented Apr 18, 2017

The instructions in the README for running from source are:

# Install dependency https://github.com/willthames/ansible-lint
git clone https://github.com/willthames/ansible-review
export PYTHONPATH=$PYTHONPATH:`pwd`/ansible-review/lib
export PATH=$PATH:`pwd`/ansible-review/bin

There's no /ansible-review/bin sub-folder, so these instructions don't work?
@dflock dflock mentioned this issue May 4, 2017
Open
willthames added a commit that referenced this issue May 5, 2017
@willthames
Reintroduce bin/ansible-review
ed25fed 
Restructure entry points and add shim for bin/ansible-review
Appears to meet recommendations in
https://chriswarrick.com/blog/2014/09/15/python-apps-the-right-way-entry_points-and-scripts/

Fixes #20
willthames added a commit that referenced this issue May 5, 2017
@willthames
Reintroduce bin/ansible-review
350c878 
Restructure entry points and add shim for bin/ansible-review
Appears to meet recommendations in
https://chriswarrick.com/blog/2014/09/15/python-apps-the-right-way-entry_points-and-scripts/

Fixes #20
@willthames
Copy link
Owner

Found a way to reintroduce the script while retaining python setuptools entry points

willthames added a commit that referenced this issue May 8, 2017
@willthames
Reintroduce bin/ansible-review
758c127 
Restructure entry points and add shim for bin/ansible-review
Appears to meet recommendations in
https://chriswarrick.com/blog/2014/09/15/python-apps-the-right-way-entry_points-and-scripts/

Fixes #20
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dflock @willthames