add temporary fix allowing use of 'delta' in

wilson-eft · Dec 15, 2023 · 15e3436 · 15e3436
1 parent 8025ccb
commit 15e3436
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/wilson/classes.py b/wilson/classes.py
@@ -47,6 +47,18 @@ def set_default_option(cls, key, value):
 
         Note that this does not affect existing instances or the instance
         called from."""
+        ####################################################################
+        ### temporary fix to keep backwards compatibility after renaming ###
+        ### of 'delta' to 'gamma' in the parameters dictionary           ###
+        ####################################################################
+        if key == 'parameters' and 'delta' in value:
+            warnings.warn("Using the parameter 'delta' is deprecated. "
+                          "Please use 'gamma' instead. Support for using "
+                          "'delta' will be removed in the future.",
+                          FutureWarning)
+            value['gamma'] = value['delta']
+            del value['delta']
+        ####################################################################
         cls._default_options.update(cls._option_schema({key: value}))
 
     def set_option(self, key, value):
@@ -60,8 +72,9 @@ def set_option(self, key, value):
         ####################################################################
         if key == 'parameters' and 'delta' in value:
             warnings.warn("Using the parameter 'delta' is deprecated. "
-                          "Please use 'gamma' instead. Support for 'delta' "
-                          "will be removed in the future.", FutureWarning)
+                          "Please use 'gamma' instead. Support for using "
+                          "'delta' will be removed in the future.",
+                          FutureWarning)
             value['gamma'] = value['delta']
             del value['delta']
         ####################################################################

diff --git a/wilson/test_wilson.py b/wilson/test_wilson.py
@@ -166,6 +166,11 @@ def test_config_parameters(self):
             w.set_option('parameters', {'delta': 1.})
             self.assertEqual(len(warns), 1)
             self.assertTrue(issubclass(warns[-1].category, FutureWarning))
+        with warnings.catch_warnings(record=True) as warns:
+            warnings.simplefilter("always")
+            w.set_default_option('parameters', {'delta': 1.})
+            self.assertEqual(len(warns), 1)
+            self.assertTrue(issubclass(warns[-1].category, FutureWarning))
         # int should be OK but corced to float
         w.set_option('parameters', {'bla': 1})
         self.assertTrue(type(w.get_option('parameters')['bla']), float)