Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

48: preserve the order of templates inside the HtmxResponse #49

Merged
merged 2 commits into from
Jul 20, 2023
Merged

48: preserve the order of templates inside the HtmxResponse #49

merged 2 commits into from
Jul 20, 2023

Conversation

klu2
Copy link
Contributor

@klu2 klu2 commented Jul 17, 2023

Fixes #48

@checketts
Copy link
Collaborator

I like it. I wanted this very thing few weeks ago. Not because it was required, just because it make the response more confusing otherwise.

@wimdeblauwe
Copy link
Owner

Thank you for this! Can you add this commit also to the PR: e31b257

It is an extra test that the order is also ok when merging HtmxResponse objects. After that, I will merge your PR.

@klu2
Copy link
Contributor Author

klu2 commented Jul 19, 2023

did so

@wimdeblauwe wimdeblauwe merged commit 79f21bd into wimdeblauwe:main Jul 20, 2023
1 check passed
@klu2 klu2 deleted the 48 branch July 20, 2023 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Preserve the order of templates inside HtmxResponse
3 participants
@klu2 @checketts @wimdeblauwe