Fix a number of apparent bugs and minor clean-up.

[jrfnl]

On a whim, I've run the codebase through Scrutinizer (without any specific config) and this threw up some interesting findings.

This PR handles most of these (for the sniff files).

Typical issues found & handled in this PR:

• Returning false from the process() method. This is wrong. If the process method returns something it will be interpreted as an integer stack position to continue checking from, so returning false could lead to race conditions.
• Variables which are set and subsequently never used.
• Strict(er) checking of variables before/when using them
• Function calls within loops
• Minor documentation inconsistencies
• A particular typo

Also:

• Removed trailing spaces

One thing Scrutinizer threw up which is not (yet) handled is the following from the BaseSniffTest.php file:

    /**
     * Tear down after each test
     *
     * @return void
     */
    public function tearDown()
    {
        // Reset any settingsStandard (targetPhpVersion)
        self::$phpcs->cli->settingsStandard = array();
    }

The PHP_CodeSniffer_CLI class does not have a settingsStandard property, so this code is effectively useless. All the same, I imagine something like this does need to be done, so someone more familiar with the original intend of this code might want to have a look at what this should be replaced with.

[wimg]

Wow pretty amazing work. Sadly there seems to be a conflict preventing the merge :-(

[jrfnl]

Rebased, should be ok to merge now (once travis has finished).