Improve ForbiddenEmptyListAssignment sniff (code review).
#166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Trigger error when there are only comments between the parenthesis. * Trigger error when there are empty parenthesis between the list parenthesis. * Don't trigger error for unfinished code when review is used during live coding (in an editor). * Slightly simplify the code. * Remove unnecessary `sprintf()`. Includes unit tests demonstrating the issue with the comments. Includes some extra unit tests for valid list assignments. As there are now more test cases, refactored the unit tests to use data providers as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sprintf().Includes unit tests demonstrating the issue with the comments and the parenthesis.
Includes some extra unit tests for valid list assignments.
As there are now more test cases, refactored the unit tests to use data providers as well.