Improve ParameterShadowSuperGlobals sniff (code review).
#180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems this sniff was missed both when implementing the `PHPCompatibility_Sniff` base class as well as when the unit tests were added. This PR fixes that. Changes: * Let class extend `PHPCompatibility_Sniff`. * Use the `supportsAbove()` function for the compatibility check. * Defer to the PHPCS native `getMethodParameters()` method for getting the parameter names. * Do a case-insensitive parameter name compare. While variable names are case-insensitive in PHP, it would still be a really bad idea to bypass the "parameter shadowing super globals" issue by using a lowercase version of the variable name. * Add unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems this sniff was missed both when implementing the
PHPCompatibility_Sniffbase class as well as when the unit tests were added.This PR fixes that.
Changes:
PHPCompatibility_Sniff.supportsAbove()function for the compatibility check.getMethodParameters()method for getting the parameter names.