Skip to content
This repository has been archived by the owner on Oct 6, 2022. It is now read-only.

Adding ZFS Snapshot support #32

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

joriankarstark
Copy link
Contributor

A first pass at adding in ZFS snapshot support.

I'm not sure if this is the best way to detect if ZFS is installed on root. Happy to take feedback and make edits. Especially in regards to snapshot names, zfs on root detection, and output messaging. Also, should we prompt the user if a snapshot is desired or just automatically take the snapshot as it is currently coded? My thought is to just take the snapshot as there is no downside that I'm aware of.

@troyBORG
Copy link

I think we might have to add a update-grub into it.
As I've been testing it seems that as soon as I shutdown I will get an empty grub screen on next boot.

@joriankarstark
Copy link
Contributor Author

Cool, thanks for testing that. I'll add in an update-grub and see how it works.

@joriankarstark
Copy link
Contributor Author

joriankarstark commented Jul 13, 2020

Hmm... update-grub wasn't enough to fix it. I don't think this issue is directly related to the snapshot being taken. It seems something happens when switching to devel-repo with zfs on root? Will try to look further into this...

Edit:
I believe it was some upstream issue that is now fixed. I was able to reproduce this earlier today, however now on latest version of groovy I can no longer see an issue after applying the rolling-rhino script. Should be good for further code review.

@troyBORG
Copy link

troyBORG commented Jul 14, 2020

It seems to be a bug that as soon as it takes another snapshot after switching to rolling that it is what breaks it.

@flexiondotorg flexiondotorg self-requested a review August 10, 2020 10:53
Copy link
Member

@flexiondotorg flexiondotorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a feature like this is added then snapshots should be made using zsys.

@joriankarstark
Copy link
Contributor Author

Ah, I was unaware of zsys. Let me see what I can do with it.

@IceTrayz
Copy link

Doesn't ZSys already take a snapshot every time a update is invoked?

@joriankarstark
Copy link
Contributor Author

It does, but not until after we modify a bunch of config files in this case. I was thinking would be good to have a snapshot taken before we touch anything.

@joriankarstark
Copy link
Contributor Author

Using zsys now. Still not sure if we should prompt the user for a zfs snapshot. But I think it's ready for review :)

@IceTrayz
Copy link

I was thinking would be good to have a snapshot taken before we touch anything.

Very good point and manual snapshot is also needed when you consider the amount of desktop changes people make outside of updates.

Thanks for working on this as it will save a lot of headaches , i find ZFS so confusing. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants