Skip to content

Commit

Permalink
Fix error I made! (#509)
Browse files Browse the repository at this point in the history
* Update BUILD.gn

* Update internal_plugin_renderer_helpers.cc

* Typo fix

* Clang lint

* revert pdf change as per win32ss guidance

* Fix omnibox radius and border flag

* Update layout_provider.cc

* /O2

* Always fully optimize in release builds.

* Update about_flags.cc

* Only apply /O2 if this isn't a debug build

* Fix error I made

Self explanatory.

---------

Co-authored-by: Shane Fournier <93808768+win32ss@users.noreply.github.com>
  • Loading branch information
Alex313031 and win32ss committed Apr 24, 2024
1 parent 2be1015 commit 2c1eb08
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion chrome/browser/ui/views/location_bar/location_bar_view.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1171,7 +1171,11 @@ void LocationBarView::RefreshBackground() {
// Keep the views::Textfield in sync. It needs an opaque background to
// correctly enable subpixel AA.
omnibox_view_->SetBackgroundColor(background_color);
if (base::CommandLine::ForCurrentProcess()->HasSwitch("classic-omnibox-border"))
if (base::CommandLine::ForCurrentProcess()->HasSwitch("classic-omnibox") &&
base::CommandLine::ForCurrentProcess()->HasSwitch("compact-ui"))
// When the location bar is shrunken, the border above is only drawn on the sides.
// To resolve this, an extra border is drawn in that area on the top and bottom.
// Ideally, only one border would be drawn.
omnibox_view_->SetBorder(views::CreateSolidSidedBorder(gfx::Insets::TLBR(1, 0, 1, 0), SK_ColorGRAY));
SchedulePaint();
}
Expand Down

0 comments on commit 2c1eb08

Please sign in to comment.