Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error I made! #509

Merged
merged 15 commits into from
Apr 24, 2024
Merged

Fix error I made! #509

Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
be0830c
Update BUILD.gn
Alex313031 Apr 15, 2024
fb74238
Update internal_plugin_renderer_helpers.cc
Alex313031 Apr 15, 2024
463ee22
Typo fix
Alex313031 Apr 15, 2024
ce0884b
Clang lint
Alex313031 Apr 15, 2024
6a8560b
revert pdf change as per win32ss guidance
Alex313031 Apr 15, 2024
e52e8c6
Merge branch 'win32ss:main' into main
Alex313031 Apr 22, 2024
e0dd657
Fix omnibox radius and border flag
Alex313031 Apr 22, 2024
d6588f8
Update layout_provider.cc
Alex313031 Apr 22, 2024
a4b6f64
/O2
Alex313031 Apr 22, 2024
24aaced
Always fully optimize in release builds.
Alex313031 Apr 22, 2024
64ab770
Update about_flags.cc
Alex313031 Apr 22, 2024
7d6a987
Only apply /O2 if this isn't a debug build
Alex313031 Apr 22, 2024
c3f1a89
Merge branch 'main' into main
win32ss Apr 23, 2024
c3c16ea
Merge branch 'win32ss:main' into main
Alex313031 Apr 24, 2024
ca75dab
Fix error I made
Alex313031 Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion chrome/browser/ui/views/location_bar/location_bar_view.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1171,7 +1171,11 @@ void LocationBarView::RefreshBackground() {
// Keep the views::Textfield in sync. It needs an opaque background to
// correctly enable subpixel AA.
omnibox_view_->SetBackgroundColor(background_color);
if (base::CommandLine::ForCurrentProcess()->HasSwitch("classic-omnibox-border"))
if (base::CommandLine::ForCurrentProcess()->HasSwitch("classic-omnibox") &&
base::CommandLine::ForCurrentProcess()->HasSwitch("compact-ui"))
// When the location bar is shrunken, the border above is only drawn on the sides.
// To resolve this, an extra border is drawn in that area on the top and bottom.
// Ideally, only one border would be drawn.
omnibox_view_->SetBorder(views::CreateSolidSidedBorder(gfx::Insets::TLBR(1, 0, 1, 0), SK_ColorGRAY));
SchedulePaint();
}
Expand Down