Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion for docs with NeoBundle. #199

Closed
jordwalke opened this issue Jan 26, 2016 · 2 comments
Closed

Suggestion for docs with NeoBundle. #199

jordwalke opened this issue Jan 26, 2016 · 2 comments

Comments

@jordwalke
Copy link

You might like to combine the installation instructions for installing/building into one command for NeoBundle. Something like this might work:

NeoBundle "https://github.com/wincent/command-t", {
       \ 'build' : {
       \     'windows' : 'cd ruby/command-t && ruby extconf.rb && make',
       \     'cygwin' : 'cd ruby/command-t && ruby extconf.rb && make',
       \     'mac' : 'cd ruby/command-t && ruby extconf.rb && make',
       \     'unix' : 'cd ruby/command-t && ruby extconf.rb && make',
       \    },
       \ }
@wincent
Copy link
Owner

wincent commented Jan 26, 2016

Thanks for the suggestion.

We'd probably want a make clean in there too, to blow away any previously built versions (the user might have changed Ruby versions, for example).

The tricky part is that the Makefile won't exist on the first run. I am not sure how to do the conditional on Windows. Something like this would work everywhere else, I think:

cd ruby/command-t && { test -f Makefile && make clean || true } && ruby extconf.rb && make

I guess it could just be:

cd ruby/command-t && ruby extconf.rb && make clean && make

instead.

wincent added a commit that referenced this issue Jan 31, 2016
As suggested here:

  #199

I don't use NeoBundle myself, but I installed it temporarily to confirm
that this works. Given that I didn't verify this on other platforms
(like "cygwin" and "windows") I left those out. The "unix" build command
runs on OS X ("mac") and presumably "linux" too, obviating the need to
specify those explicitly (the commands would be the same anyway).
@wincent
Copy link
Owner

wincent commented Jan 31, 2016

I pushed something like this into the docs, so closing this for now. Thanks once again for the suggestion!

@wincent wincent closed this as completed Jan 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants