-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow c
option for confirmation when using Acks
#17
Comments
So I just took a look and I think that the sanity check that is being done here just needs to be removed. It was a good thought, but there are too many variables for how a user can decide to create a substitution pattern. Passing the value through with no checks is the better option. Let |
I'm open to making the sanity check more flexible, but not removing it.
|
@wincent I'll look into it. |
I'm thinking it can be as simple as changing the regex to something like |
@wincent was something like this merged in? |
Yes. See the commit linked above (937d61b), currently in master. |
Cool! Thanks! |
Mass find and replace is a great first step, but I typically always confirm each of my replacements. Currently if you try to do something like
:Acks /foo/bar/c
it throws an error. My guess is that you're just passing this toargdo
in which case any options should be sent verbatim toargdo
. Including if the user chooses to do a find/replace with something other than/
as the delimiter.For example:
:Acks -some/thing/with/slashes-another/thing/with/slashes-c
The text was updated successfully, but these errors were encountered: