Allow c option for confirmation when using Acks

[jfelchner]

Mass find and replace is a great first step, but I typically always confirm each of my replacements. Currently if you try to do something like :Acks /foo/bar/c it throws an error. My guess is that you're just passing this to argdo in which case any options should be sent verbatim to argdo. Including if the user chooses to do a find/replace with something other than / as the delimiter.

For example: :Acks -some/thing/with/slashes-another/thing/with/slashes-c

[jfelchner]

So I just took a look and I think that the sanity check that is being done here just needs to be removed. It was a good thought, but there are too many variables for how a user can decide to create a substitution pattern. Passing the value through with no checks is the better option. Let argdo blow up if something isn't right.

[wincent]

I'm open to making the sanity check more flexible, but not removing it.
On Sat, Aug 1, 2015 at 2:06 AM Jeff Felchner notifications@github.com
wrote:

So I just took a look and I think that the sanity check that is being done
here
https://github.com/wincent/ferret/blob/master/autoload/ferret/private.vim#L242-L245
just needs to be removed. It was a good thought, but there are too many
variables for how a user can decide to create a substitution pattern.
Passing the value through with no checks is the better option. Let argdo
blow up if something isn't right.

—
Reply to this email directly or view it on GitHub
#17 (comment).

[jfelchner]

@wincent I'll look into it.

[wincent]

I'm thinking it can be as simple as changing the regex to something like '\v^(.).+\1.*\1c?$, and then passing the c through if present.

[jfelchner]

@wincent was something like this merged in?

[wincent]

Yes. See the commit linked above (937d61b), currently in master.

[jfelchner]

Cool! Thanks!