Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [KD-3647] upgrade packages #281

Merged
merged 2 commits into from
Jul 15, 2022
Merged

Conversation

hanpeter
Copy link
Contributor

@hanpeter hanpeter commented Jul 15, 2022

Description

This PR adds apk update && apk upgrade in all Dockerfiles to avoid vulnerabilities

How Has This Been Tested?

$ docker build -f docker/helm/Dockerfile -t winchci/helm:dev .
...
$ docker scan winchci/helm:dev
...
Tested 2 projects, no vulnerable paths were found.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@hanpeter hanpeter requested a review from sethyates as a code owner July 15, 2022 20:50
@@ -1,6 +1,6 @@
FROM alpine:latest
ENV DOCKER_CONFIG /etc/docker
RUN apk add --update --no-cache curl docker git openssh-client zip
RUN apk update && apk upgrade && apk add --update --no-cache curl docker git openssh-client zip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no caching please

@sethyates sethyates merged commit 883dc76 into winchci:main Jul 15, 2022
@hanpeter hanpeter deleted the peter-scan branch July 15, 2022 20:54
@hanpeter hanpeter mentioned this pull request Jul 15, 2022
9 tasks
@hanpeter hanpeter changed the title chore: upgrade packages chore: [KD-3647] upgrade packages Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants