Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macros Window for UGS Platform #352

Merged
merged 2 commits into from
May 7, 2016
Merged

Macros Window for UGS Platform #352

merged 2 commits into from
May 7, 2016

Conversation

rugbymauri
Copy link
Contributor

Hi Will i created a Macros Module for the UGS Platform. Macros can be edited and will be stored in a file. Each macro will add a Button with the Macro.

@codecov-io
Copy link

Current coverage is 15.72%

Merging #352 into master will decrease coverage by -0.05% as of 052b563

@@            master    #352   diff @@
======================================
  Files           73      73       
  Stmts         6465    6485    +20
  Branches       739     741     +2
  Methods          0       0       
======================================
  Hit           1020    1020       
  Partial         89      89       
- Missed        5356    5376    +20

Review entire Coverage Diff as of 052b563

Powered by Codecov. Updated on successful CI builds.

@rugbymauri
Copy link
Contributor Author

btw. i used http://glyphicons.com/ for the Icons

@winder
Copy link
Owner

winder commented Feb 21, 2016

I haven't run the code yet, but I noticed you added a new property file for
the macros. You should be able to access the macros in the classic GUI via
the Settings object. You can get it from the CentralLookup.

I'll take a closer look at the PR later today, I've got a busy morning.

What was your impression after building a plugin? Did you find the tutorial
I wrote?

On Sunday, February 21, 2016, rugbymauri notifications@github.com wrote:

btw. i used http://glyphicons.com/ for the Icons


Reply to this email directly or view it on GitHub
#352 (comment)
.

@rugbymauri
Copy link
Contributor Author

Yes i used the turorial. i just strait forward. Great

i looked the the Settingd in the Central Lookup. But for my macros (it more an "CustomButtons") i need two fields: a title and the Code. in the Settings i only can store the Gcode.

@winder
Copy link
Owner

winder commented Feb 22, 2016

@rugbymauri There is actually a name/description attached to each Macros stored in the settings now. Take a look at Macro.java and Settings.java:updateMacro/getMacro.

@philreindl cleaned up all that code in #326

@winder winder merged commit 101584d into winder:master May 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants