Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: optimize utils/color.ts #708

Merged
merged 8 commits into from
Feb 25, 2022
Merged

perf: optimize utils/color.ts #708

merged 8 commits into from
Feb 25, 2022

Conversation

notsatvrn
Copy link
Contributor

@notsatvrn notsatvrn commented Feb 24, 2022

hsl2rgb performance increased by ~10%
toRGB performance increased by ~50%

performance measurements were gathered using my own tests with random colors

@notsatvrn notsatvrn changed the title optimize utils/color.ts perf: optimize utils/color.ts Feb 24, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #708 (81607f1) into main (bb0341d) will decrease coverage by 0.00%.
The diff coverage is 70.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #708      +/-   ##
==========================================
- Coverage   88.13%   88.13%   -0.01%     
==========================================
  Files          57       57              
  Lines        4873     4872       -1     
  Branches     1039     1040       +1     
==========================================
- Hits         4295     4294       -1     
+ Misses        313      312       -1     
- Partials      265      266       +1     
Impacted Files Coverage Δ
src/utils/color.ts 78.18% <70.37%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb0341d...81607f1. Read the comment docs.

@antfu antfu merged commit c6d5094 into windicss:main Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants