Adding some of the pieces needed for supporting image assets #101
Conversation
Support for embedded images in Lottie files. Introducing the WinUIXamlMediaData project so we can bring in LoadedImageSource for loading images.
| @@ -452,6 +452,71 @@ Asset ParseAsset(JsonReader reader) | |||
| throw EofException; | |||
| } | |||
|
|
|||
| static ImageAsset CreateImageAsset(string id, double width, double height, string imagePath, string fileName) | |||
There was a problem hiding this comment.
static [](start = 8, length = 6)
Just curious, but why does this need to be static? #ByDesign
There was a problem hiding this comment.
Doesn't need to be, but I like to make methods static whenever they can be. It tells the reader that it does not depend on any object state, which helps local reasoning.
In reply to: 277075711 [](ancestors = 277075711)
The CompositionSurfaceBase made sense when the only implementations of ICompositionSurface were also CompositionObjects. But with support for LoadedImageSurface that all changes. This change is only part of the solution - in order to support LoadedImageSurface without introducing a circular dependency between WinCompData and WinUIXamlData we will need to add a new project for anything that needs to refer to both of them, i.e. the ObjectGraph, Instantiator, Optimizer, codegen, and the dumpers.
Adding CleanObjs.cmd script to easily delete all obj directories. This can be useful when diagnosing build issues because the regular clean doesn't delete objs.
| return GetCompositionVisualSurface((CompositionVisualSurface)obj); | ||
|
|
||
| case "LoadedImageSurface": // Not yet implemented. |
There was a problem hiding this comment.
"LoadedImageSurface" [](start = 21, length = 20)
why not use nameof(LoadedImageSurface)? #ByDesign
There was a problem hiding this comment.
Can't do that yet because it would create a dependency from WinCompData to WinUIXamlMediaData. After the next refactoring we can fix this.
In reply to: 277395773 [](ancestors = 277395773)
| Reference(from, (CompositionObject)obj); | ||
| return true; | ||
|
|
||
| case "LoadedImageSurface": // Not yet implemented. |
There was a problem hiding this comment.
"LoadedImageSurface" [](start = 21, length = 20)
why not use nameof(LoadedImageSurface)? #ByDesign
There was a problem hiding this comment.
Can't do that yet because it would create a dependency from WinCompData to WinUIXamlMediaData. After the next refactoring we can fix this.
In reply to: 277395826 [](ancestors = 277395826)
| new XAttribute(nameof(imageAsset.Width), imageAsset.Width), | ||
| new XAttribute(nameof(imageAsset.Height), imageAsset.Height), | ||
| new XAttribute(nameof(imageAsset.Format), imageAsset.Format), | ||
| new XAttribute(nameof(imageAsset.Bytes), imageAsset.Bytes.Length)); |
There was a problem hiding this comment.
nameof(imageAsset.Bytes), imageAsset.Bytes.Length [](start = 31, length = 49)
Length of byte array is outputted for the "Bytes" attribute. That's misleading. #Resolved
| { "Width", asset.Width }, | ||
| { "Height", asset.Height }, | ||
| { "Format", asset.Format}, | ||
| { "Bytes", asset.Bytes.Length}, |
There was a problem hiding this comment.
"Bytes", asset.Bytes.Length [](start = 18, length = 27)
"BytesArrayLength" to be exact? #Resolved
Support for embedded images in Lottie files.
Introducing the WinUIXamlMediaData project so we can bring in LoadedImageSource for loading images.