Refactoring code that references WinUIXamlMediaData and WinCompData to UIData. #104
Conversation
| public static readonly Color White = Color.FromArgb(255, 255, 255, 255); | ||
| public static readonly Color WhiteSmoke = Color.FromArgb(255, 245, 245, 245); | ||
| public static readonly Color Yellow = Color.FromArgb(255, 255, 255, 0); | ||
| public static readonly Color YellowGreen = Color.FromArgb(255, 154, 205, 50); | ||
| } | ||
| } |
There was a problem hiding this comment.
@simeoncran So does stylecop just complain about this (no newline at the end) but not do anything? #WontFix
There was a problem hiding this comment.
Is it complaining on your machine? I don't see any complains on mine.
In reply to: 278657261 [](ancestors = 278657261)
There was a problem hiding this comment.
I see it in the github ui. Just wondering how stylecop is actually enforced; not a blocker to merging. #WontFix
There was a problem hiding this comment.
Stylecop runs the set of rules that we tell it to run. For some files we turn off some rules. Perhaps this was suppressed before and isn't any more.
In reply to: 278657261 [](ancestors = 278657261)
| @@ -19,17 +19,17 @@ sealed class CodeBuilder | |||
|
|
|||
| internal bool IsEmpty => _lines.Count == 0; | |||
|
|
|||
| internal void WriteLine() | |||
There was a problem hiding this comment.
This file should be moved into UIData and methods should go back to internal. This is really just an implementation detail of the CodeGen code. #Resolved
|
|
||
| /// <summary> | ||
| /// A simple non-extensible node type. | ||
| /// </summary> |
There was a problem hiding this comment.
[](start = 21, length = 1)
I don't see Graph and ObjectGraph in UIData. How can it build without them? #Resolved
There was a problem hiding this comment.
These two files were already added to UIData in the last PR.
In reply to: 279119575 [](ancestors = 279119575)
This is the second and final part of the refactoring. Code that will reference WinUIXamlMediaData and WinCompData is moved to UIData.