Handling Opacity on Layers. #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliezerpMS
reviewed
May 18, 2019
| opacityNode.Children.Add(rootNode); | ||
| rootNode = opacityNode; | ||
|
|
||
| if (!layerOpacityPercent.IsAnimated) |
There was a problem hiding this comment.
!layerOpacityPercent.IsAnimated [](start = 20, length = 31)
Should this not have the "!"? #Resolved
There was a problem hiding this comment.
plaiMS
reviewed
May 20, 2019
| rectangle.FillBrush = CreateAnimatedColorBrush(context, layer.Color, context.TrimAnimatable(layer.Transform.OpacityPercent)); | ||
| // If the layer has masks then the opacity is set on a Visual in the chain returned | ||
| // for the layer from TryCreateContainerVisualTransformChain. | ||
| // If there no masks then the opacity needs to be animated on the brush. |
There was a problem hiding this comment.
[](start = 23, length = 1)
there is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.