Prepare for gradients #143
Conversation
Previously the output depended on the width of the console, and sorting ignored case.
| @@ -125,6 +128,12 @@ void Reference(T from, CompositionObject obj) | |||
| case CompositionObjectType.CompositionGeometricClip: | |||
| VisitCompositionGeometricClip((CompositionGeometricClip)obj, node); | |||
| break; | |||
| case CompositionObjectType.CompositionLinearGradientBrush: | |||
There was a problem hiding this comment.
case CompositionObjectType.CompositionLinearGradientBrush: [](start = 15, length = 59)
Should these be placed alphabetically? #Resolved
|
|
||
| public Animatable<double> OpacityPercent { get; } | ||
|
|
||
| public abstract ShapeFillKind FillKind { get; } |
There was a problem hiding this comment.
FillKind [](start = 38, length = 8)
Is this going to be used for something later? #ByDesign
There was a problem hiding this comment.
Yep... in the translator we will have a ShapeFill in the context for a shape layer and we need to switch on the kind of fill.
In reply to: 318817982 [](ancestors = 318817982)
| return GetCompositionLinearGradientBrush((Wd.CompositionLinearGradientBrush)obj); | ||
| case Wd.CompositionObjectType.CompositionRadialGradientBrush: | ||
| // TODO - handle versioning - RadialGradientBrush was not added until 1903 | ||
| // return GetCompositionRadialGradientBrush((Wd.CompositionRadialGradientBrush)obj); |
There was a problem hiding this comment.
GetCompositionRadialGradientBrush [](start = 34, length = 33)
Should we just gate this behind the same thing that the mattes and masks is gates behind? #Resolved
There was a problem hiding this comment.
I did not intend to leave a TODO in here. I will finish the implementation.
FYI, for versioning (which I expect to start next week) we will have 2 different modes: backward compatible, and requires version.
- Backward compatible will not blow up if you're on a version that doesn't support a Comp feature - it will render something but possibly won't look awesome.
- Requires version will not try to be backward compatible, but will have a version check during loading.
In reply to: 318818408 [](ancestors = 318818408)
Changes needed to implement gradient support.
Includes some refactoring and cleanup that I want to get out of the way now rather than including in the more complicated stuff needed to translate gradients.