WINDUPRULE-137 Catchall rules should have Optional severity #133
Conversation
| @@ -30,10 +30,10 @@ | |||
| </not> | |||
| </when> | |||
| <perform> | |||
| <classification title="Doug Lea Concurrency util" severity="mandatory"> | |||
| <classification title="Doug Lea Concurrency util" severity="potential"> | |||
There was a problem hiding this comment.
IMO, this one should just be optional. I can't imagine a reason for it to be mandatory for an EAP migration.
The same would apply to the other concurrency backport ones.
There was a problem hiding this comment.
Optional and not potential? Potential is more than optional? And does "potential" imply that it's a mandatory change? I'm a bit confused.
There was a problem hiding this comment.
Well, it is really weird for this to be a catchall rule to begin with, IMO.
There was a problem hiding this comment.
Frankly I am not against to recategorized it. Just for a reminding, these all catch rules was to mimic the Windup 0.7 feature which identified some general packages.
|
I agree. Can we mention you at the meeting to make sure we are all on the same page? |
|
This just needs a rebase, I think. |
OndraZizka
added
Ready to Review
Reviewed/Ready to Merge
and removed
Reviewed/Needs Adjustment
Reviewed/Ready to Merge
labels
|
Rebased. |
I'm giving them "Potential" severity, as it seems that's what the user really wants. Correct me if I am wrong.