Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WINDUPRULE-137 Catchall rules should have Optional severity #133

Merged
merged 1 commit into from Apr 25, 2016
Merged

WINDUPRULE-137 Catchall rules should have Optional severity #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .gitignore
View file
Open in desktop
Expand Up @@ -25,3 +25,8 @@ atlassian-ide-plugin.xml
/nbactions.xml
*-test-result.html
rexster.xml
rules-reviewed/CreateIDs.xsl
rules-reviewed/CreateTests.xsl
rules-reviewed/tags.txt
tags.txt

4 changes: 2 additions & 2 deletions rules-reviewed/eap6/jrun/jrun-catchall.windup.xml
View file
Open in desktop
Expand Up @@ -21,7 +21,7 @@
<javaclass references="jrun.{*}" />
</when>
<perform>
<classification title="JRun" effort="0" severity="mandatory">
<classification title="JRun" effort="0" severity="potential">
<tag>catchall</tag>
<tag>jrun</tag>
</classification>
Expand All @@ -32,7 +32,7 @@
<javaclass references="jrunx.{*}" />
</when>
<perform>
<classification title="JRunX" effort="0" severity="mandatory">
<classification title="JRunX" effort="0" severity="potential">
<tag>catchall</tag>
<tag>jrun</tag>
</classification>
Expand Down
16 changes: 8 additions & 8 deletions rules-reviewed/eap6/uncategorized/generic-catchall.windup.xml
View file
Open in desktop
Expand Up @@ -30,10 +30,10 @@
</not>
</when>
<perform>
<classification title="Doug Lea Concurrency util" severity="mandatory">
<classification title="Doug Lea Concurrency util" severity="potential">
Copy link
Member

@jsight jsight Apr 21, 2016 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, this one should just be optional. I can't imagine a reason for it to be mandatory for an EAP migration.

The same would apply to the other concurrency backport ones.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional and not potential? Potential is more than optional? And does "potential" imply that it's a mandatory change? I'm a bit confused.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it is really weird for this to be a catchall rule to begin with, IMO.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frankly I am not against to recategorized it. Just for a reminding, these all catch rules was to mimic the Windup 0.7 feature which identified some general packages.

<tag>catchall</tag>
</classification>
<hint effort="0" severity="mandatory" title="Doug Lea Concurrency type reference">
<hint effort="0" severity="potential" title="Doug Lea Concurrency type reference">
<message>
This is an old Doug Lea Concurrency util type and needs to be migrated to a compatible java.util.concurrent API. There is currently no detailed
information about this type.
Expand All @@ -59,9 +59,9 @@
</not>
</when>
<perform>
<hint effort="0" severity="mandatory" title="backport-util-concurrent type reference">
<hint effort="0" severity="potential" title="backport-util-concurrent type reference">
<message>
This type is the backport of java.util.concurrent API, introduced in Java 5.0 and further refined in Java 6.0, to older Java platforms.
This type is the backport of java.util.concurrent API, introduced in Java 5.0 and further refined in Java 6.0, to older Java platforms.
You should use java.util.concurrent API instead.
</message>
<tag>catchall</tag>
Expand All @@ -85,8 +85,8 @@
<classification title="Mule API" severity="optional">
<tag>catchall</tag>
</classification>
<hint effort="0" severity="mandatory" title="Mule API org.mule.{package-remainder}.{type} reference">
<message>Mule API org.mule.{package-remainder}.{type} was used. You should convert these types to Apache Camel.
<hint effort="0" severity="potential" title="Mule API org.mule.{package-remainder}.{type} reference">
<message>Mule API org.mule.{package-remainder}.{type} was used. You should convert these types to Apache Camel.
</message>
<link href="http://camel.apache.org" title="Apache Camel"/>
<tag>catchall</tag>
Expand Down Expand Up @@ -117,7 +117,7 @@
<classification title="MX4J" severity="optional" effort="0">
<tag>catchall</tag>
</classification>
<hint effort="0" severity="mandatory" title="MX4J type reference">
<hint effort="0" severity="potential" title="MX4J type reference">
<message>MX4J mx4j.{package-remainder}.{type} reference was used.</message>
<tag>catchall</tag>
<tag>mx4j</tag>
Expand Down Expand Up @@ -147,7 +147,7 @@
<classification title="Apache Tuscany" severity="optional" effort="0">
<tag>catchall</tag>
</classification>
<hint effort="0" severity="mandatory" title="Apache Tuscany type reference">
<hint effort="0" severity="potential" title="Apache Tuscany type reference">
<message>Apache Tuscany org.osoa.sca.annotations.{type} reference was used.</message>
<tag>catchall</tag>
<tag>soa</tag>
Expand Down
16 changes: 8 additions & 8 deletions rules-reviewed/eap6/weblogic/weblogic-catchall.windup.xml
View file
Open in desktop
Expand Up @@ -27,7 +27,7 @@
</not>
</when>
<perform>
<hint effort="0" severity="mandatory" title="Proprietary type reference found">
<hint effort="0" severity="potential" title="Proprietary type reference found">
<message>
This is an Oracle proprietary type (`com.bea{subpackage}.{type}`) and needs to be migrated to a compatible API. There is currently no detailed
information about this type.
Expand Down Expand Up @@ -56,7 +56,7 @@
</not>
</when>
<perform>
<hint effort="0" severity="mandatory" title="Proprietary type reference found">
<hint effort="0" severity="potential" title="Proprietary type reference found">
<message>
This is an Oracle proprietary type (`com.oracle{subpackage}.{type}`) and needs to be migrated to a compatible API. There is currently no detailed
information about this type.
Expand Down Expand Up @@ -85,7 +85,7 @@
</not>
</when>
<perform>
<hint effort="0" severity="mandatory" title="Proprietary type reference found">
<hint effort="0" severity="potential" title="Proprietary type reference found">
<message>
This is an Oracle proprietary type (`com.tangosol{subpackage}.{type}`) and needs to be migrated to a compatible API. There is currently no detailed
information about this type.
Expand Down Expand Up @@ -114,7 +114,7 @@
</not>
</when>
<perform>
<hint effort="0" severity="mandatory" title="Proprietary type reference found">
<hint effort="0" severity="potential" title="Proprietary type reference found">
<message>
This is an Oracle proprietary type (`com.weblogic{subpackage}.{type}`) and needs to be migrated to a compatible API. There is currently no detailed
information about this type.
Expand Down Expand Up @@ -143,7 +143,7 @@
</not>
</when>
<perform>
<hint effort="0" severity="mandatory" title="Oracle proprietary type reference">
<hint effort="0" severity="potential" title="Oracle proprietary type reference">
<message>
This is an Oracle proprietary type (`bea.{remainder}`) and needs to be migrated to a compatible API. There is currently no detailed
information about this type.
Expand All @@ -169,7 +169,7 @@
</not>
</when>
<perform>
<hint effort="0" severity="mandatory" title="Oracle proprietary type reference">
<hint effort="0" severity="potential" title="Oracle proprietary type reference">
<message>
This is an Oracle proprietary type (`oracle.{remainder}`) and needs to be migrated to a compatible API. There is currently no detailed
information about this type.
Expand All @@ -195,7 +195,7 @@
</not>
</when>
<perform>
<hint effort="0" severity="mandatory" title="Oracle proprietary type reference">
<hint effort="0" severity="potential" title="Oracle proprietary type reference">
<message>
This is an Oracle proprietary type (`oracle.sql.{remainder}`) and needs to be migrated to a compatible API. There is currently no detailed
information about this type.
Expand All @@ -221,7 +221,7 @@
</not>
</when>
<perform>
<hint effort="0" severity="mandatory" title="Oracle proprietary type reference">
<hint effort="0" severity="potential" title="Oracle proprietary type reference">
<message>
This is an Oracle proprietary type (`weblogic.{remainder}`) and needs to be migrated to a compatible API. There is currently no detailed
information about this type.
Expand Down
4 changes: 2 additions & 2 deletions rules-reviewed/eap6/websphere/websphere-catchall.windup.xml
View file
Open in desktop
Expand Up @@ -29,7 +29,7 @@
</not>
</when>
<perform>
<hint effort="0" severity="mandatory" title="IBM proprietary type reference">
<hint effort="0" severity="potential" title="IBM proprietary type reference">
<message>
This is an IBM proprietary type ({package}.{type}) and needs to be migrated to a compatible API. There is currently no detailed
information about this type.
Expand Down Expand Up @@ -58,7 +58,7 @@
</not>
</when>
<perform>
<hint effort="0" severity="mandatory" title="IBM ILog proprietary type reference">
<hint effort="0" severity="potential" title="IBM ILog proprietary type reference">
<message>
This is an IBM ILog proprietary type (ilog.{subpackage}.{type}) and needs to be migrated to a compatible API. There is currently no detailed
information about this type.
Expand Down
4 changes: 2 additions & 2 deletions rules-reviewed/fuse/sonic-catchall.windup.xml
View file
Open in desktop
Expand Up @@ -30,8 +30,8 @@
</not>
</when>
<perform>
<classification title="Sonic" severity="mandatory" />
<hint effort="0" severity="mandatory" title="Sonic proprietary type reference com.{subpackage}.{classname}">
<classification title="Sonic" severity="potential" />
<hint effort="0" severity="potential" title="Sonic proprietary type reference com.{subpackage}.{classname}">
<message>
This com.{subpackage}.{classname} is a Sonic proprietary type and needs to be migrated to a compatible API. There are currently no detailed
migration rules about this type.
Expand Down